From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] Fix tst_mkfs_ doc
Date: Tue, 1 Feb 2022 12:58:31 +0100 [thread overview]
Message-ID: <YfkgZ8Ab6Jl8udbv@yuki> (raw)
In-Reply-To: <20220126164703.7177-1-pvorel@suse.cz>
Hi!
> diff --git a/include/old/test.h b/include/old/test.h
> index 2ae7dba71f..87287a8e7e 100644
> --- a/include/old/test.h
> +++ b/include/old/test.h
> @@ -193,7 +193,8 @@ int self_exec(const char *argv0, const char *fmt, ...);
> * @dev: path to a device
> * @fs_type: filesystem type
> * @fs_opts: NULL or NULL terminated array of mkfs options
> - * @extra_opt: extra mkfs option which is passed after the device name
> + * @extra_opts: NULL or NULL terminated array of extra mkfs options which is
^
are
> + * passed after the device name.
> */
> #define tst_mkfs(cleanup, dev, fs_type, fs_opts, extra_opts) \
> tst_mkfs_(__FILE__, __LINE__, cleanup, dev, fs_type, \
> diff --git a/include/tst_mkfs.h b/include/tst_mkfs.h
> index b89bf812f6..c2d777facd 100644
> --- a/include/tst_mkfs.h
> +++ b/include/tst_mkfs.h
> @@ -9,7 +9,8 @@
> * @dev: path to a device
> * @fs_type: filesystem type
> * @fs_opts: NULL or NULL terminated array of extra mkfs options
> - * @extra_opts: NULL or NULL terminated array of extra mkfs options
> + * @extra_opts: NULL or NULL terminated array of extra mkfs options which is
^
are
> + * passed after the device name.
> */
> void tst_mkfs_(const char *file, const int lineno, void (cleanup_fn)(void),
> const char *dev, const char *fs_type,
With the minor mistake fixed:
Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-01 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 16:47 [LTP] [PATCH 1/1] Fix tst_mkfs_ doc Petr Vorel
2022-02-01 11:58 ` Cyril Hrubis [this message]
2022-02-01 15:28 ` Petr Vorel
2022-02-01 16:06 ` Richard Palethorpe
2022-02-01 17:24 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfkgZ8Ab6Jl8udbv@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox