From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 467CBC433F5 for ; Fri, 18 Feb 2022 06:50:41 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 714423CA0D2 for ; Fri, 18 Feb 2022 07:50:39 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C44DE3C9893 for ; Fri, 18 Feb 2022 07:50:30 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 433BF200239 for ; Fri, 18 Feb 2022 07:50:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0B1B0210F2; Fri, 18 Feb 2022 06:50:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1645167029; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ws+xxMKEgNMx+rSNl1TkQFpWj9fgW8uaI/D71aBNhZM=; b=ng2J0Z77elowUUZfxbD9TBX4OqnpZgzZQuRxrbaUO8wNsP8qZbsaTL7xBfwMRpdN9+8OKt xHwQRjldWxQAylru2NbMKLte5H/hmb13bkV+92bUe8RqxAOGeYyepUfiBLcXTez2syzxDI hYq2dkAxryGDdHH77ATIJVfFBTiT78E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1645167029; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ws+xxMKEgNMx+rSNl1TkQFpWj9fgW8uaI/D71aBNhZM=; b=PkzLifuPIdiRqgrdx354103PA4l8asitAwNk+KXTtrRXp+OYpZr8ZIx7BXQUKPXjK0chtf mGvaVd3t8iG68VAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DD7A013A15; Fri, 18 Feb 2022 06:50:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VpUxNLRBD2JEKAAAMHmgww (envelope-from ); Fri, 18 Feb 2022 06:50:28 +0000 Date: Fri, 18 Feb 2022 07:50:27 +0100 From: Petr Vorel To: "xuyang2018.jy@fujitsu.com" Message-ID: References: <1645005868-2373-1-git-send-email-xuyang2018.jy@fujitsu.com> <1645005868-2373-5-git-send-email-xuyang2018.jy@fujitsu.com> <620F1768.7060100@fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <620F1768.7060100@fujitsu.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 5/5] syscalls/pidfd_getfd02: add basic error test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: "ltp@lists.linux.it" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Xu, > > and get more info. > I will look Cyril's patch and wait. Thx! > >> + if (!TST_PASS) > >> + tst_brk(TFAIL | TTERRNO, "pidfd_open failed"); > > @Cyril: would it be possible to to allow using also tst_brk() in macros in > > tst_test_macros.h? > Maybe can add SAFE_PIDFD_OPEN. I was thinking about it. But you use TFAIL - part of testing. But using just SAFE_PIDFD_OPEN() even it's using TBROK might be best. Kind regards, Petr > > Having TST_*_BRK() (i.e. TST_EXP_FD_SILENT_BRK()) looks too complicated -- Mailing list info: https://lists.linux.it/listinfo/ltp