From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] lib: Rename array used for .all_filesystems flag
Date: Tue, 8 Feb 2022 14:16:21 +0100 [thread overview]
Message-ID: <YgJtJeKJz9Ne+BBu@yuki> (raw)
In-Reply-To: <YfFeXoHL5iTx4QNh@pevik>
Hi!
> > Although fs_type_whitelist[] is also used for whitelisting with
> > .skip_filesystems, the main purpose is to be used for .all_filesystems.
>
> > Thus rename it to all_filesystems[].
>
> NOTE: the main purpose of this change is to increase code readability.
> https://lore.kernel.org/ltp/CAEemH2fNfFes-eUtiQKX9JJxqEQUQ+O5nWQM8G-yNyTo8sxviw@mail.gmail.com/
>
> That's why I added doc.
I guess that fs_type_whitelist[] may be confusing but all_filesystems[]
is IMHO not that much better since we use that a as base for the
all_filesystem before we filter out these that are not supported. Maybe
we should call it try_filesystems[] instead?
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-08 13:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 14:11 [LTP] [PATCH 1/1] lib: Rename array used for .all_filesystems flag Petr Vorel
2022-01-26 14:44 ` Petr Vorel
2022-02-08 13:16 ` Cyril Hrubis [this message]
2022-02-08 15:00 ` Petr Vorel
2022-02-08 15:08 ` Cyril Hrubis
2022-02-08 17:23 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgJtJeKJz9Ne+BBu@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox