From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 3/5] tst_test.sh: Add $TST_FORMAT_DEVICE and related vars
Date: Tue, 8 Feb 2022 18:36:40 +0100 [thread overview]
Message-ID: <YgKqKM32COAnmxfo@pevik> (raw)
In-Reply-To: <YgJ6dOD7tC+7UQL2@yuki>
Hi Cyril,
> > +++ b/doc/shell-test-api.txt
...
> > +| 'TST_FS_TYPE' | Overwrite the default filesystem to be used.
> ^
> Override?
+1, thanks!
> > diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
...
> > + if [ "$TST_FORMAT_DEVICE" = 1 ]; then
> > + tst_mkfs "$TST_FS_TYPE" "$TST_DEVICE" "$TST_DEV_FS_OPTS" "$TST_DEV_EXTRA_OPTS"
> This would work with the proposed change to tst_mkfs if we swapped the
> $TST_DEV_FS_OPTS with $TST_DEVICE.
Do you mean to swap here? i.e.:
tst_mkfs "$TST_FS_TYPE" "$TST_DEV_FS_OPTS" "$TST_DEVICE" "$TST_DEV_EXTRA_OPTS"
But in tst_mkfs it has always been the second parameter:
local device=${2:-$TST_DEVICE}
What am I missing?
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-08 17:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 18:12 [LTP] [PATCH 0/5] shell: Add TST_FORMAT_DEVICE support Petr Vorel
2022-01-26 18:12 ` [LTP] [PATCH 1/5] tst_test.sh: Add $TST_DEFAULT_FS_TYPE Petr Vorel
2022-02-08 13:47 ` Cyril Hrubis
2022-02-08 18:20 ` Petr Vorel
2022-01-26 18:12 ` [LTP] [PATCH 2/5] tst_test.sh: tst_mkfs(): Add support for extra opts Petr Vorel
2022-02-08 14:06 ` Cyril Hrubis
2022-02-08 18:08 ` Petr Vorel
2022-02-08 18:28 ` Petr Vorel
2022-02-09 16:05 ` Petr Vorel
2022-02-09 16:13 ` Petr Vorel
2022-01-26 18:12 ` [LTP] [PATCH 3/5] tst_test.sh: Add $TST_FORMAT_DEVICE and related vars Petr Vorel
2022-02-08 14:13 ` Cyril Hrubis
2022-02-08 17:36 ` Petr Vorel [this message]
2022-02-08 17:58 ` Cyril Hrubis
2022-02-08 18:26 ` Petr Vorel
2022-01-26 18:12 ` [LTP] [PATCH 4/5] df01.sh: Use TST_FORMAT_DEVICE=1 Petr Vorel
2022-01-26 18:12 ` [LTP] [PATCH 5/5] shell: Add test for TST_FORMAT_DEVICE=1 Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgKqKM32COAnmxfo@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox