From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25BD6C433F5 for ; Fri, 11 Feb 2022 08:59:29 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9D91E3C9EF1 for ; Fri, 11 Feb 2022 09:59:27 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 82E023C9B4B for ; Fri, 11 Feb 2022 09:59:18 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 8410910007FF for ; Fri, 11 Feb 2022 09:59:17 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 139351F385; Fri, 11 Feb 2022 08:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1644569956; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FZTMMpebvO10BlJso/4ZNpLDBi4V/gxFF1k4c2EOzXA=; b=X59Bl6S2RyJ14vtgB/vRTv76A8cQvRcNI5cyH81BMxvLJhe59nkGIXRaAzoC9+gCOUqv7/ H/UJcahMf/5MdRxpR66N0kvMCeYFSezoschvH7mmRAut1AMDH9qxcP8zUbVqiNnKF9DFtB FotTtEXzRnqaIKAxCxLQFjJzLBHtl6Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1644569956; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FZTMMpebvO10BlJso/4ZNpLDBi4V/gxFF1k4c2EOzXA=; b=vNeiFnOQtGjv5tDUHtpQhhyclf2BkUHDA9ZGvlwlxvY8iXLvjA5olOwfsmhxXyf7GhXRdY gMUSlM/75PyH4cCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C97F813345; Fri, 11 Feb 2022 08:59:15 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RWqGL2MlBmIyBgAAMHmgww (envelope-from ); Fri, 11 Feb 2022 08:59:15 +0000 Date: Fri, 11 Feb 2022 09:59:14 +0100 From: Petr Vorel To: "xuyang2018.jy@fujitsu.com" Message-ID: References: <20220210133812.13368-1-bogdan.lezhepekov@suse.com> <6205BA38.7070903@fujitsu.com> <62061EC1.2040206@fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <62061EC1.2040206@fujitsu.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v1] mem/swapping01: Make sure swap is supported by kernel X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: LTP List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi all, > Hi Bogdan > > Hi all, > > I didn't go for CONFIG_SWAP just because wanted to be aligned with > > syscalls/swapon/swapon03.c and to not multiply patterns. > > If you see CONFIG_SWAP more beneficial for docparser, I can make another > > patch. > > Should I? > IMO, yes, but let's listen voice from other maintainers. > @Petr,@Cyril We have 3 options. 1) keep check access("/proc/swaps", F_OK) 2) use .needs_config for "CONFIG_SWAP=y" 3) Add .needs_swap flag to struct tst_test To be honest, I'm not sure, what's the best, probably .needs_config. I worried little bit about .needs_config forcing config to be available in the past, but that should be solved KCONFIG_SKIP_CHECK added by Xu. Kind regards, Petr > Best Regards > Yang Xu > > Cheers, > > Bogdan > > ------------------------------------------------------------------------ > > *From:* ltp on > > behalf of xuyang2018.jy@fujitsu.com > > *Sent:* Friday, February 11, 2022 3:21 > > *To:* Li Wang > > *Cc:* LTP List > > *Subject:* Re: [LTP] [PATCH v1] mem/swapping01: Make sure swap is > > supported by kernel > > Hi Li > >> On Fri, Feb 11, 2022 at 12:09 AM Cyril Hrubis >> > wrote: > >> Hi! > >> Applied, thanks. > >> I guess that the SAFE_OPEN() caused TBROK on machines without > >> CONFIG_SWAP, right? > >> If so, why not go fix with .needs_config for "CONFIG_SWAP=y" ? > > +1, it is also friendly to docparse. > > ps: I never listen user complaint for the lack of CONFIG_PORC, so only > > using .needs_config for "CONFIG_SWAP=y" can work well. > > Best Regards > > Yang Xu > >> -- > >> Regards, > >> Li Wang -- Mailing list info: https://lists.linux.it/listinfo/ltp