Re: [LTP] [COMMITTED][PATCH 1/1] ustat: Add missing space in known-fail

[Petr Vorel <pvorel@suse.cz>]

Hi,

> Although testinfo.pl in a7b6c94503 adds extra space for producing doc,
> space was missing when printing after test run:

> $ ./ustat01
> ...
> HINT: You _MAY_ be hit by known kernel failures:

> ustat() is known to fail with EINVAL on Btrfs, seehttps://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/

> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> We might just remove the space from docparse/testinfo.pl which is now
> useless:

> diff --git docparse/testinfo.pl docparse/testinfo.pl
> index 67e435d794..fa77b53cc5 100755
> --- docparse/testinfo.pl
> +++ docparse/testinfo.pl
> @@ -456,7 +456,7 @@ sub content_all_tests
>  			# tag value value can be split into more lines if too long
>  			# i.e. URL in known-fail
>  			for (@$tag[2 .. $#$tag]) {
> -				$v .= " $_";
> +				$v .= $_;
>  			}

>  			$content .= "\n|" . reference($k) . "\n|$v\n";

Ah, I confused patchwork (patchwork bug?). The change in docparse/testinfo.pl
was just a suggestion (under first ---).

The real committed change starts below.

Kind regards,
Petr

>  testcases/kernel/syscalls/ustat/ustat01.c | 2 +-
>  testcases/kernel/syscalls/ustat/ustat02.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

> diff --git a/testcases/kernel/syscalls/ustat/ustat01.c b/testcases/kernel/syscalls/ustat/ustat01.c
> index 66dbc0b184..70a44adb46 100644
> --- a/testcases/kernel/syscalls/ustat/ustat01.c
> +++ b/testcases/kernel/syscalls/ustat/ustat01.c
> @@ -45,7 +45,7 @@ static struct tst_test test = {
>  	.test_all = run,
>  	.setup = setup,
>  	.tags = (const struct tst_tag[]) {
> -		{"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see"
> +		{"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see "
>  			"https://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/"
>  		},
>  		{}
> diff --git a/testcases/kernel/syscalls/ustat/ustat02.c b/testcases/kernel/syscalls/ustat/ustat02.c
> index 55bdcaedf8..a5b0cc1b68 100644
> --- a/testcases/kernel/syscalls/ustat/ustat02.c
> +++ b/testcases/kernel/syscalls/ustat/ustat02.c
> @@ -64,7 +64,7 @@ static struct tst_test test = {
>  	.setup = setup,
>  	.tcnt = ARRAY_SIZE(tc),
>  	.tags = (const struct tst_tag[]) {
> -		{"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see"
> +		{"known-fail", "ustat() is known to fail with EINVAL on Btrfs, see "
>  			"https://lore.kernel.org/linux-btrfs/e7e867b8-b57a-7eb2-2432-1627bd3a88fb@toxicpanda.com/"
>  		},
>  		{}

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp