From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E16AC433EF for ; Wed, 16 Feb 2022 08:51:22 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id CAC7F3CA08F for ; Wed, 16 Feb 2022 09:51:19 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 23ECF3CA056 for ; Wed, 16 Feb 2022 09:51:10 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 9811B1A014E2 for ; Wed, 16 Feb 2022 09:51:09 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 839971F383; Wed, 16 Feb 2022 08:51:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1645001468; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1aUsJjV8uKBEPydYJSoKgquFoGxx0vqTWsne6ev3MmE=; b=hQgMlByslhdHYHIpWfh2INJjgEt1vIkCCpO03E8mwwJVfWY12vnaTw13OlP3z5VFGxv1eW rFng3GXvNlolmw7Ri/knrYzsJC+ilIZ4ktXR+JEPgdeFyZLAj8ffSqjErruEa++JSi9xo3 pNktLjFSyrqp0YmSrRKEMR6IQDEWDeM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1645001468; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1aUsJjV8uKBEPydYJSoKgquFoGxx0vqTWsne6ev3MmE=; b=NPS54TpGMggznGwW/MynQCuG+KtWQGA56LG1Gbdh/MVTRjw4Zrm29Pa3kS8v1pj4osAXAp 3nzdVAIc5A/f+vDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C37D13A7C; Wed, 16 Feb 2022 08:51:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RGUuFPy6DGKoWwAAMHmgww (envelope-from ); Wed, 16 Feb 2022 08:51:08 +0000 Date: Wed, 16 Feb 2022 09:51:06 +0100 From: Petr Vorel To: Bogdan Lezhepekov Message-ID: References: <20220216074800.22621-1-blezhepekov@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220216074800.22621-1-blezhepekov@suse.de> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2] lib/safe_file_ops.c: Fix resource leak X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Bogdan, > safe_file_scanf and safe_file_vprintf suffered > from resource leak, as opened file descriptor > was not closed in case of error. I guess we don't care about closing file descriptor in both safe_file_scanf() and safe_file_vprintf() because test exits due used tst_brkm_(). And we *do* care in file_printf() with err: label because we don't exit there (tst_resm_() does not exit). But instead, you could replace fopen() / fclose() which is followed by tst_brkm_() by safe_fopen() / safe_fclose() (to shorten the code). Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp