From: Petr Vorel <pvorel@suse.cz>
To: "xuyang2018.jy@fujitsu.com" <xuyang2018.jy@fujitsu.com>
Cc: Martin Doucha <martin.doucha@suse.com>,
"ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 2/3] quotactl08: Use do_mount()
Date: Tue, 1 Mar 2022 11:17:53 +0100 [thread overview]
Message-ID: <Yh3y0b7WRfYfBWHF@pevik> (raw)
In-Reply-To: <621DD533.50509@fujitsu.com>
Hi Xu,
...
> >>>>> to change
> >>>>> quotactl08.c:160: TBROK: mount(/dev/loop0, mntpoint, ext4, 0, (nil)) failed: ESRCH (3)
> >>>> I doubt why fs quota is not supported on this case since we have check
> >>>> kernel config?
> >>> There is probably bug on the SUT, thus it might be correct it fails.
> >>> But how about martin's fix 4aab31e4c7 ("syscalls/quotactl: Skip tests if FS
> >>> quota is not supported") - quotactl04.c also checks for CONFIG_QFMT_V2 and uses
> >>> do_mount(). I'll check whether it was another bug on the system.
> >> Maybe we miss check the following kernel config?
> > In my case it's probably a problem with mkfs.
> Another possible way about loop driver. So do you use default loop image
> to create ext4 filesystem or export LTP_DEV?
FYI: in our case it was JeOS broken due missing quota_v2 kernel driver
(JeOS tries to be minimal, so it's always a fiddling between space and
functionality). I'm still not sure if we want to add check for .needs_drivers
quota_v2.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-03-01 10:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 15:32 [LTP] [PATCH 0/3] quotactl ESRCH fixes Petr Vorel
2022-02-23 15:32 ` [LTP] [PATCH 1/3] quotactl: Move do_mount() to header Petr Vorel
2022-02-23 15:32 ` [LTP] [PATCH 2/3] quotactl08: Use do_mount() Petr Vorel
2022-02-24 1:47 ` xuyang2018.jy
2022-02-28 13:49 ` Petr Vorel
2022-02-28 16:19 ` Petr Vorel
2022-03-01 1:11 ` xuyang2018.jy
2022-03-01 7:58 ` Petr Vorel
2022-03-01 8:10 ` xuyang2018.jy
2022-03-01 10:17 ` Petr Vorel [this message]
2022-03-03 11:41 ` Martin Doucha
2022-03-03 12:55 ` Petr Vorel
2022-03-03 11:38 ` Martin Doucha
2022-03-04 2:57 ` xuyang2018.jy
2022-02-23 15:32 ` [LTP] [PATCH 3/3] quotactl09: " Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh3y0b7WRfYfBWHF@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=martin.doucha@suse.com \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox