From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Martin Doucha <martin.doucha@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [RFC??[DO_NOT_MERGE][PATCH v2 1/1] netstress: Fix race between SETSID() and exit(0)
Date: Mon, 21 Feb 2022 14:26:41 +0100 [thread overview]
Message-ID: <YhOTEWKaPpn9Z3yX@yuki> (raw)
In-Reply-To: <YhOQAEHFCeMkrYsE@pevik>
Hi!
> > tst_res_ TINFO "run server 'netstress $s_opts'"
> > tst_res_ TINFO "run client 'netstress -l $c_opts' $run_cnt times"
>
>
> Yes, this looks like enough. Do you want me to merge this proposal with added
> this change? Or you send a patch or just merge fix yourself?
Just merge it all into a single patch.
> > However the debugging took longer than I wanted to since the network
> > tests are such a mess. The server does exit by TBROK (which looks like
> > it's an expected behavior), only half of the sever log is printed on a
> > failure, etc. These should really deserve some cleanups...
> I'd say specifically tst_netload() (in tst_net.sh) and netstress.c deserve
> cleanup. Also, as we noticed several times shell tests tends to be buggy,
> specially in combination with C tests. But not sure if feasible to write
> everything in C.
I guess that we can do some minor fixes, but the whole codebase looks
like it needs to be rethinked and redesigned...
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-02-21 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 16:48 [LTP] [RFCŊ[DO_NOT_MERGE][PATCH v2 1/1] netstress: Fix race between SETSID() and exit(0) Petr Vorel
2022-02-18 17:28 ` Petr Vorel
2022-02-21 13:05 ` [LTP] [RFC??[DO_NOT_MERGE][PATCH " Cyril Hrubis
2022-02-21 13:13 ` Petr Vorel
2022-02-21 13:26 ` Cyril Hrubis [this message]
2022-02-21 13:36 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhOTEWKaPpn9Z3yX@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=martin.doucha@suse.com \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox