Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 04/10] Rewrite sem_nstest.c using new LTP API
Date: Thu, 10 Mar 2022 16:54:51 +0100	[thread overview]
Message-ID: <YiofSy6GPq9Z/3rC@yuki> (raw)
In-Reply-To: <20220310105916.7960-5-andrea.cervesato@suse.de>

Hi!
> +	ipc_id = semget(MY_KEY, 1, IPC_CREAT | IPC_EXCL | 0666);
> +	if (ipc_id < 0) {
> +		tst_res(TINFO, "Semaphore already exists");
> +		ipc_id = SAFE_SEMGET(MY_KEY, 1, 0);
>  	}
> +}

Same here, I do not think that we should blindly reuse existing
semaphore.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-03-10 15:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 10:59 [LTP] [PATCH v2 00/10] Rewrite sysvipc testing suite using new LTP API Andrea Cervesato
2022-03-10 10:59 ` [LTP] [PATCH v2 01/10] Rewrite mesgq_nstest.c " Andrea Cervesato
2022-03-10 14:16   ` Cyril Hrubis
2022-03-14 12:23     ` Andrea Cervesato via ltp
2022-03-15 12:38       ` Cyril Hrubis
2022-03-10 10:59 ` [LTP] [PATCH v2 02/10] Rewrite msg_comm.c " Andrea Cervesato
2022-03-10 15:19   ` Cyril Hrubis
2022-03-10 10:59 ` [LTP] [PATCH v2 03/10] Rewrite sem_comm.c " Andrea Cervesato
2022-03-10 15:43   ` Cyril Hrubis
2022-03-10 10:59 ` [LTP] [PATCH v2 04/10] Rewrite sem_nstest.c " Andrea Cervesato
2022-03-10 15:54   ` Cyril Hrubis [this message]
2022-03-10 10:59 ` [LTP] [PATCH v2 05/10] Rewrite semtest_2ns.c " Andrea Cervesato
2022-03-10 16:37   ` Cyril Hrubis
2022-03-10 10:59 ` [LTP] [PATCH v2 06/10] Rewrite shm_comm.c " Andrea Cervesato
2022-03-10 17:01   ` Cyril Hrubis
2022-03-10 10:59 ` [LTP] [PATCH v2 07/10] Rewrite shmem_2nstest.c " Andrea Cervesato
2022-03-10 10:59 ` [LTP] [PATCH v2 08/10] Rewrite shmnstest.c " Andrea Cervesato
2022-03-10 10:59 ` [LTP] [PATCH v2 09/10] Remove libclone dependency from sysvipc Andrea Cervesato
2022-03-10 10:59 ` [LTP] [PATCH v2 10/10] Delete obsolete ipcns_helper.h in sysvipc suite Andrea Cervesato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YiofSy6GPq9Z/3rC@yuki \
    --to=chrubis@suse.cz \
    --cc=andrea.cervesato@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox