From: Petr Vorel <pvorel@suse.cz>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3] kernel/fs/fsnotify-stress: fsnotify stress test
Date: Thu, 10 Mar 2022 21:48:58 +0100 [thread overview]
Message-ID: <YipkOjYIeY4NbQuh@pevik> (raw)
In-Reply-To: <YiiDlHcCscQqPJBi@yuki>
Hi,
...
> > +static struct tst_test test = {
> > + .tcnt = 1,
> > + .forks_child = 1,
> > + .needs_root = 1,
> > + .needs_tmpdir = 1,
> > + .needs_cmds = 0,
> > + .needs_cgroup_ver = 0,
> > + .needs_cgroup_ctrls = 0,
> Please do not set anything to 0 here, that is the default value for any
> uninitialized variables. Unfortunatelly gcc is buggy and prints warnings
> for nearly all tst_test initializations in the LTP tree, there is an
> upstream gcc bug for that that haven't been worked on for quite some
> time now. But that is not a reason to work around compiler bugs here.
FYI
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84685
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82283
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-03-10 20:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 2:47 [LTP] [PATCH 1/2] kernel/fs/fs-notify: fsnotify stress tests Murphy Zhou
2022-01-25 7:29 ` Amir Goldstein
2022-01-25 8:30 ` Murphy Zhou
2022-01-25 10:28 ` Petr Vorel
2022-01-25 10:56 ` Cyril Hrubis
2022-01-25 11:04 ` Cyril Hrubis
2022-01-27 4:42 ` Murphy Zhou
2022-02-28 6:29 ` Murphy Zhou
2022-02-28 6:42 ` Petr Vorel
2022-03-03 3:06 ` [LTP] [PATCH v2] kernel/fs/fsnotify-stress: fsnotify stress test Murphy Zhou
2022-03-03 15:22 ` Petr Vorel
2022-03-04 3:28 ` Murphy Zhou
2022-03-08 1:38 ` [LTP] [PATCH v3] " Murphy Zhou
2022-03-09 10:38 ` Cyril Hrubis
2022-03-10 20:48 ` Petr Vorel [this message]
2022-09-02 7:58 ` Murphy Zhou
2022-09-02 8:17 ` [LTP] [PATCH v4] " Murphy Zhou
2022-10-17 9:40 ` Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YipkOjYIeY4NbQuh@pevik \
--to=pvorel@suse.cz \
--cc=jencce.kernel@gmail.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox