From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BFFFC433F5 for ; Fri, 11 Mar 2022 12:41:46 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 52CEC3C8CAF for ; Fri, 11 Mar 2022 13:41:44 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 0A0BA3C8B2E for ; Fri, 11 Mar 2022 13:41:29 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 6514D1400B90 for ; Fri, 11 Mar 2022 13:41:29 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 99DD61F381; Fri, 11 Mar 2022 12:41:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1647002488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tIFjLZDlNjFTpJLUVF7emcUIvNanuHQaU9bKtA05h0Q=; b=KY9aWCA0+xWQTPixsKDAEHI3U2AjWI3E2Vg1VFWAwi2WqJ4l2RM2QgvecBLvXg2BzYe0oZ uAFkRN1hUD4WrABNXiTJW1adrdwf+QWoT5HqgENGjM6xjf8OAlpVKXuw+fAn+0tRaXNSiO jJENjG+gL7eSt8pWQGmCBU2CUbg0/zM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1647002488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tIFjLZDlNjFTpJLUVF7emcUIvNanuHQaU9bKtA05h0Q=; b=tGqV3ob8fXOdjXvNYqAtVMtquyZ3RaSUL3lMhJVVw0A/f7+RBsGGVHwItDFv2ECIqthE9M 1UTzFBF0ZUmPW6Cg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 85A5713A85; Fri, 11 Mar 2022 12:41:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UdLIH3hDK2KWOwAAMHmgww (envelope-from ); Fri, 11 Mar 2022 12:41:28 +0000 Date: Fri, 11 Mar 2022 13:43:47 +0100 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20220311110015.20951-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220311110015.20951-1-pvorel@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/1] nfs01_open_files: Fix pattern for deleted files X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Brown , ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > Reported-by: Neil Brown > Signed-off-by: Petr Vorel > --- > testcases/network/nfs/nfs_stress/nfs01_open_files.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/testcases/network/nfs/nfs_stress/nfs01_open_files.c b/testcases/network/nfs/nfs_stress/nfs01_open_files.c > index 9342f11ba9..c5627058dc 100644 > --- a/testcases/network/nfs/nfs_stress/nfs01_open_files.c > +++ b/testcases/network/nfs/nfs_stress/nfs01_open_files.c > @@ -10,7 +10,8 @@ > #include > #include > > -#define TEMPLATE "ltpXXXXXX" > +#define TEMPLATE_PREFIX "ltp" > +#define TEMPLATE TEMPLATE_PREFIX "XXXXXX" > > int write_something(int); > void delete_files(void); > @@ -101,7 +102,7 @@ void delete_files(void) > > dirp = opendir("."); > for (entp = readdir(dirp); entp; entp = readdir(dirp)) > - if (!strncmp(entp->d_name, "apt", 3)) { > + if (!strncmp(entp->d_name, TEMPLATE_PREFIX, 3)) { Maybe we should also do: #define TEMPLATE_PREFIX_LEN (sizeof(TEMPLATE_PREFIX) - 1) And use TEMPLATE_PREFIX_LEN instead of the hardcoded 3 Otherwise it looks obviously correct: Reviewed-by: Cyril Hrubis -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp