From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7B71C433FE for ; Fri, 25 Mar 2022 10:07:15 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id C2D4E3C8813 for ; Fri, 25 Mar 2022 11:07:13 +0100 (CET) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C8D963C0354 for ; Fri, 25 Mar 2022 11:07:02 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id 442D11A011DF for ; Fri, 25 Mar 2022 11:07:01 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 698981F7AC; Fri, 25 Mar 2022 10:07:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648202821; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L7OLV1+nidTssVJIyUt/Y5J7Y1AMXyGX7WRpc20S4yU=; b=lVktUEIKpGdYxJon9R4g/MVjUpW7ZwWnL9Eu/THzXUyHFhUnqMUBXoyWz8D5ZLJj+xaz+k r9TSG9918Jc/TaQqmV/lg6I+8LcYqIrKRX6Z0F8qW5hYwWdUY70J27zvARzKki1hs8m3uJ mIrWjUq5I9Ndsda2MUGfy79jNnC4EyM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648202821; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L7OLV1+nidTssVJIyUt/Y5J7Y1AMXyGX7WRpc20S4yU=; b=mM8VjhObmZBZlN8+uOqrIUFhIiVEICHKYZwDYFNQbBAGFy1lfqYJkupokWfHzYjMIUa0FK 6I7ZE7v1PbG/4YBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 40FB613A30; Fri, 25 Mar 2022 10:07:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wYz3DUWUPWKNEgAAMHmgww (envelope-from ); Fri, 25 Mar 2022 10:07:01 +0000 Date: Fri, 25 Mar 2022 11:06:59 +0100 From: Petr Vorel To: Andrea Cervesato Message-ID: References: <20220315122351.8556-1-andrea.cervesato@suse.de> <20220315122351.8556-2-andrea.cervesato@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 1/8] Rewrite userns01.c using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Andrea, > > > +static inline void updatemap(int cpid, bool type, int idnum, int parentmappid) > > nit: This header should #include , not all tests (they use UID_MAP, > > thus they don't need it). > I think this will be replaced with integer, according also with the if/else > statement which is below and use switch to check its value as well. +1 Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp