Linux Test Project
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] tools/sparse-ltp: Check all struct arrays in tst_test for ending {}
Date: Tue, 15 Mar 2022 10:14:41 +0100	[thread overview]
Message-ID: <YjBZAUelR7ExR83A@pevik> (raw)
In-Reply-To: <20220314130630.9378-1-rpalethorpe@suse.com>

Hi Richie,

> Check for null termination on tst_test.save_restore and all the other
> struct arrays in tst_test. They are all null terminated.

> Also prevents a segfault when scalar NULL is used as the final entry
> and print a helpful error message instead.

thanks for this! LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-03-15  9:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-14 13:06 [LTP] [PATCH 1/2] tools/sparse-ltp: Check all struct arrays in tst_test for ending {} Richard Palethorpe via ltp
2022-03-14 13:06 ` [LTP] [PATCH 2/2] LTP-005: Switch opts terminator to {} Richard Palethorpe via ltp
2022-03-15  9:15   ` Petr Vorel
2022-03-15  9:14 ` Petr Vorel [this message]
2022-03-15 12:53   ` [LTP] [PATCH 1/2] tools/sparse-ltp: Check all struct arrays in tst_test for ending {} Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjBZAUelR7ExR83A@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox