Linux Test Project
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] waitid10: Fix when coredumps are piped
Date: Mon, 21 Mar 2022 16:29:16 +0100	[thread overview]
Message-ID: <YjiZzFPvjC+PcMyq@yuki> (raw)
In-Reply-To: <87ils7corb.fsf@suse.de>

Hi!
> Reviewed-by: Richard Palethorpe <rpalethorpe@suse.com>
> 
> BTW I thought that division by zero actually just resulted in zero or
> INT_MAX on some platforms? (e.g. ARM)
> 
> It's undefined behaviour, so I fail to see how this test has ever worked
> on some architectures. Perhaps we should dereference a null/invalid
> pointer instead?

That wouldn't work since we are trying to get SIGFPE not SIGSEGV.

See:

http://patchwork.ozlabs.org/project/ltp/patch/20220310105533.3012-1-chrubis@suse.cz/

Also if you can review this patch as well...

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2022-03-21 15:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 13:38 [LTP] [PATCH] waitid10: Fix when coredumps are piped Cyril Hrubis
2022-03-21 15:17 ` Richard Palethorpe
2022-03-21 15:29   ` Cyril Hrubis [this message]
2022-03-22 12:21   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YjiZzFPvjC+PcMyq@yuki \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox