From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51F16C433FE for ; Wed, 23 Mar 2022 10:17:56 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 020E93C9643 for ; Wed, 23 Mar 2022 11:17:54 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 3E6BE3C3040 for ; Wed, 23 Mar 2022 11:17:44 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id A4D071400BC2 for ; Wed, 23 Mar 2022 11:17:43 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E934A1F38F; Wed, 23 Mar 2022 10:17:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648030662; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OcYTL9TSffgFv5WZf+84CQkSAve4i/TuNAFrL+ozwW4=; b=2/MPQoHN6eeY2vUF0EsPTxBA4pLpICt2NXwEYiE8mSTa6FvmkG46w+07vO1BqXC1B0LmTq VuEGSgd0TmqHEn3dBy/GKlQ5GEQdfqawbi+NcxlObBQUsJoQ6XxEHTkpO4C+VcbXnqRA8P X3rkEiMU0H350y1Sv2XdS67Xw2E+NF4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648030662; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OcYTL9TSffgFv5WZf+84CQkSAve4i/TuNAFrL+ozwW4=; b=xrDSf5KNdouI9GKfeZvmRqgIPLsHVLzWKyS/hmJjHAXWX19YvUNf17JJqe/O/ynDAX90Jp NYki0TpDlxhRsmDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id C61AF132BA; Wed, 23 Mar 2022 10:17:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id t/CrLsbzOmJdQgAAMHmgww (envelope-from ); Wed, 23 Mar 2022 10:17:42 +0000 Date: Wed, 23 Mar 2022 11:17:41 +0100 From: Petr Vorel To: Andrea Cervesato Message-ID: References: <20220315122351.8556-1-andrea.cervesato@suse.de> <20220315122351.8556-2-andrea.cervesato@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220315122351.8556-2-andrea.cervesato@suse.de> X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 1/8] Rewrite userns01.c using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Andrea, Reviewed-by: Petr Vorel nit: I'd sometimes use underscore to make names more readable i.e. update_map, parent_map_pid, OVERFLOW_UID_PATH, OVERFLOW_GID_PATH > +static inline int check_newuser(void) > +{ > + int pid, status; > + > + if (tst_kvercmp(3, 8, 0) < 0) > + tst_brk(TCONF, "CLONE_NEWUSER not supported"); Is this limitation needed, when we have the same check with ltp_clone_quick()? > + > + pid = ltp_clone_quick(CLONE_NEWUSER | SIGCHLD, dummy_child, NULL); > + if (pid == -1) > + tst_brk(TCONF | TTERRNO, "CLONE_NEWUSER not supported"); > + > + SAFE_WAIT(&status); > + > + return 0; > +} > + > +static inline void updatemap(int cpid, bool type, int idnum, int parentmappid) > +{ > + char path[BUFSIZ]; > + char content[BUFSIZ]; > + int fd; > + > + if (type == UID_MAP) > + sprintf(path, "/proc/%d/uid_map", cpid); > + else if (type == GID_MAP) > + sprintf(path, "/proc/%d/gid_map", cpid); > + else > + tst_brk(TBROK, "invalid type parameter"); nit: maybe switch would be more readable. ... Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp