From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C95B5C433EF for ; Wed, 23 Mar 2022 15:04:25 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id BF24E3C964F for ; Wed, 23 Mar 2022 16:04:23 +0100 (CET) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [IPv6:2001:4b78:1:20::6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 233833C00D1 for ; Wed, 23 Mar 2022 16:04:13 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 3DE431400FB6 for ; Wed, 23 Mar 2022 16:04:12 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1C4D61F387; Wed, 23 Mar 2022 15:04:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648047852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0ZZTuM6JRqu80392cdPBv/YlkKtThCUdpc8//8U7hKE=; b=0ENdLuzQvlGJ0oD4ObhN+grOPdyy1hGcaXREVx1SzmjNF4SobsOCf1+4AOqxe1hjfEJ3nh 0aI6qQXnvlHMU1g9Rfh2ZGNn1e27t1mNsRQzN6g9U05su/F1PqVP9/Xo203jN3sfPcDkwH liIZI8ZcfxjoWdAUy1lxJCaD+F6DUZ8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648047852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0ZZTuM6JRqu80392cdPBv/YlkKtThCUdpc8//8U7hKE=; b=DzeF1PWFAhj3ia8KgHv8ZZD7FbiYm9JC+kyMECVOv/3ie7KDpYA67Zn2dlReK4ln1eiVHk raBbx5Lv497YPrCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 071EE13302; Wed, 23 Mar 2022 15:04:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Xo1QAOw2O2JeXgAAMHmgww (envelope-from ); Wed, 23 Mar 2022 15:04:12 +0000 Date: Wed, 23 Mar 2022 16:06:30 +0100 From: Cyril Hrubis To: Zhao Gongyi Message-ID: References: <20220323094926.65653-1-zhaogongyi@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220323094926.65653-1-zhaogongyi@huawei.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] accept02: Add SAFE_FORK to clean CLOSE_WAIT fds X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! As far as I can tell we should rather close the fd returned from the accept() call like this: diff --git a/testcases/kernel/syscalls/accept/accept02.c b/testcases/kernel/syscalls/accept/accept02.c index 12a1e3ca3..b2d27a260 100644 --- a/testcases/kernel/syscalls/accept/accept02.c +++ b/testcases/kernel/syscalls/accept/accept02.c @@ -68,6 +68,8 @@ static void *server_thread(void *arg) TEST(setsockopt(clone_server_sockfd, SOL_IP, MCAST_LEAVE_GROUP, mc_group, mc_group_len)); + SAFE_CLOSE(clone_server_sockfd); + if (TST_RET != -1) tst_res(TFAIL, "Multicast group was copied!"); else if (TST_ERR == EADDRNOTAVAIL) -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp