From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23193C433F5 for ; Thu, 24 Mar 2022 14:19:05 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 57FB63C98BB for ; Thu, 24 Mar 2022 15:19:03 +0100 (CET) Received: from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it [IPv6:2001:4b78:1:20::7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 9BE493C07BE for ; Thu, 24 Mar 2022 15:18:53 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 05D72200D13 for ; Thu, 24 Mar 2022 15:18:52 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 43399210FD; Thu, 24 Mar 2022 14:18:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648131532; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aRMsgusi90Uzx5uvsi4WRj2EgOPVK6Nn99ham3hX6vE=; b=gtQN6DwFxsov/RvF64UI2fkiFvZxJOoUNTdC5F93mP2upYiIY8L2cWEz8p5FpDN023WUcz EyGIblUTqO7p4VyvpkGGNED3VtrRZyvSBPG8BE5Zymqv3EURRuJSgoPcOZ8E7I+3+5ihLh xwC0y1WbNDhJeSf6Xpm1ucihcrmRk/o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648131532; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aRMsgusi90Uzx5uvsi4WRj2EgOPVK6Nn99ham3hX6vE=; b=cmzS5Foo72F3tNRPzEKzdu8Y6MjM9jQdOBeDq3TRbYvBfc2YlNI8ohuXIqDDYCz3yW+J82 v+64VXiWIohfYKBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1382312FF7; Thu, 24 Mar 2022 14:18:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 1iwEA8x9PGKsAwAAMHmgww (envelope-from ); Thu, 24 Mar 2022 14:18:52 +0000 Date: Thu, 24 Mar 2022 15:18:50 +0100 From: Petr Vorel To: Andrea Cervesato Message-ID: References: <20220315122351.8556-1-andrea.cervesato@suse.de> <20220315122351.8556-9-andrea.cervesato@suse.de> <599d319f-0936-5aee-f140-39bac113baeb@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <599d319f-0936-5aee-f140-39bac113baeb@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-7.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 8/8] Rewrite userns08.c using new LTP API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Andrea, > Hi Petr, > I can check it, but it will probably take some time because I'm not familiar > with that particular scenario. Can we go ahead with the patch-set anyway? OK, I'll implement the fix in the library. And for sure this is not a blocker for your patchset. I've just haven't finishing reviewing it. Kind regards, Petr > Andrea > On 3/23/22 13:54, Petr Vorel wrote: > > > Hi! > > > > ./userns08 -i50 > > > > tst_kconfig.c:82: TINFO: Parsing kernel config '/proc/config.gz' > > > > tst_test.c:1456: TINFO: Timeout per run is 0h 05m 00s > > > > userns08.c:65: TPASS: Denied write access to ./restricted : EACCES (13) > > > > userns08.c:65: TPASS: Denied write access to ./restricted : EACCES (13) > > > > userns08.c:65: TPASS: Denied write access to ./restricted : EACCES (13) > > > > userns08.c:65: TPASS: Denied write access to ./restricted : EACCES (13) > > > > userns08.c:65: TPASS: Denied write access to ./restricted : EACCES (13) > > > > userns08.c:36: TBROK: clone3 failed: ENOSPC (28) > > > > Something needs to be closed after each run. > > > ENOSPC means that we created too many user namespaces. The problem is > > > likely that we are creating the namespaces faster than they are being > > > asynchronously cleaned up in the kernel. Adding sleep(1) to the > > > clone_newuser() function gives kernel enough time to clean the > > > namespaces and the test works with any -i. Also note that we get the > > > exact same failure if we execute the test a few times in a row, i.e. > > > for i in `seq 10`; do > > > ./userns08 > > > done > > +1 > > > The original test fails in the same way, so while it should be fixed, > > > it's not really reason to block this patchset. > > Agree (I forget to write I suspected the problem wasn't new in this patchset). > > > And the only correct fix would be retrying the clone() on ENOSPC in the > > > SAFE_CLONE(). > > +1. I suppose Andrea will have look into it (otherwise I'll do it). > > Kind regards, > > Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp