From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/3] broken_ip-nexthdr.sh: Check IPv6 support before forcing it
Date: Wed, 30 Mar 2022 11:17:21 +0200 [thread overview]
Message-ID: <YkQgIdUEMSzLCiR9@pevik> (raw)
In-Reply-To: <YkQfyh3ppXPGMarB@yuki>
> Hi!
> > I tried to implement this [1] (or [2] if I force push), and using getopts the
> > end of the script only would require also to move loading '. tst_test.sh' at the
> > end of *all* the test scripts because setup functions needs to be loaded before
> > sourcing tst_test.sh. Do we want this?
> Sounds reasonable. I would go even further and put the line that sources
> the tst_test.sh to be last line in the test.
+1, I'll also update docs examples and mention it.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-03-30 9:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 19:46 [LTP] [PATCH v2 0/3] shell: Fixes for disabled IPv6 Petr Vorel
2022-02-04 19:46 ` [LTP] [PATCH v2 1/3] tst_net.sh: Fix " Petr Vorel
2022-03-02 11:00 ` Cyril Hrubis
2022-03-02 11:05 ` Petr Vorel
2022-02-04 19:46 ` [LTP] [PATCH v2 2/3] broken_ip-nexthdr.sh: Check IPv6 support before forcing it Petr Vorel
2022-03-02 14:18 ` Cyril Hrubis
2022-03-02 20:44 ` Petr Vorel
2022-03-22 18:25 ` Petr Vorel
2022-03-30 9:15 ` Cyril Hrubis
2022-03-30 9:17 ` Petr Vorel [this message]
2022-02-04 19:46 ` [LTP] [PATCH v2 3/3] netns: Rewrite to use tst_net.sh Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YkQgIdUEMSzLCiR9@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox