From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5910C433F5 for ; Tue, 12 Apr 2022 08:58:46 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id EFCFE3CA52F for ; Tue, 12 Apr 2022 10:58:44 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [IPv6:2001:4b78:1:20::5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 5C61F3C8C82 for ; Tue, 12 Apr 2022 10:58:32 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id 5BF66600219 for ; Tue, 12 Apr 2022 10:58:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4D2AC210E3; Tue, 12 Apr 2022 08:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649753910; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7hf4yPGRkEYaUNEXTHDtZVm4wDGg6PALO7kboTKerIk=; b=hAXz0GWp+rqdSIY4hIQoXJ+Nffxw3hXMPoXYsv6r79kuZLLD1PnEQaJuGqK4Vr+gG3WAGL LC3iKv6veZoJnkFf0RhgwoHZrU/oFqoa7XK7OUkjPl6tj4ky3fjMyM+sl4a8jIzqEJ2wev zMpsUOYioU1bBhl2qYvmj8ZX26mKOco= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649753910; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7hf4yPGRkEYaUNEXTHDtZVm4wDGg6PALO7kboTKerIk=; b=SpVVDC89Na5p3OdiCdrn1Hkr38IFjGOuQwr4B5KOrnYmomUvPXK1dprkLwKKOq76w2xDsJ 4ehhJ7w9NjhQ7vBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2AEAF13780; Tue, 12 Apr 2022 08:58:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BpWVCDY/VWLeIAAAMHmgww (envelope-from ); Tue, 12 Apr 2022 08:58:30 +0000 Date: Tue, 12 Apr 2022 10:58:28 +0200 From: Petr Vorel To: Richard Palethorpe Message-ID: References: <20220329074440.26214-1-rpalethorpe@suse.com> <20220329074440.26214-3-rpalethorpe@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220329074440.26214-3-rpalethorpe@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 3/3] cgroups: Add first IO controller test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Richie, LGTM, just please remove needs_device as not needed. Reviewed-by: Petr Vorel > +static void setup(void) > +{ > + char buf[PATH_MAX] = { 0 }; > + char *path = SAFE_GETCWD(buf, PATH_MAX - sizeof("mnt") - 1); > + struct stat st; > + > + strcpy(path + strlen(path), "/mnt"); > + > + tst_stat_mount_dev(path, &st); > + dev_major = major(st.st_rdev); > + dev_minor = minor(st.st_rdev); If we ever support test setup run inside do_setup() (i.e. setup function which would be run just once - before for_each_variant(), for_each_filesystem() and fork_testrun()), this test would have use case for it (I suppose more tests which use .all_filesystems). Because tst_stat_mount_dev() could be run just for first filesystem. But that's not related to the testcase. Kind regards, Petr > +} > + > +static struct tst_test test = { > + .test_all = run, > + .setup = setup, > + .needs_device = 1, > + .mntpoint = "mnt", > + .mount_device = 1, > + .all_filesystems = 1, > + .skip_filesystems = (const char *const[]){ "ntfs", "tmpfs", NULL }, > + .needs_cgroup_ver = TST_CG_V2, > + .needs_cgroup_ctrls = (const char *const[]){ "io", NULL }, > +}; -- Mailing list info: https://lists.linux.it/listinfo/ltp