From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] sighold02: Fix muslc builds by removing __SIGRTMIN
Date: Mon, 25 Apr 2022 13:23:06 +0200 [thread overview]
Message-ID: <YmaEmnRY9CNL9+Bu@rei> (raw)
In-Reply-To: <YmaBfMmDa4O/Lc2N@pevik>
Hi!
> Ah, looking at the code "if (sig >= __SIGRTMIN && sig < SIGRTMIN)",
> we need both underscore and non-underscore.
This is code to actually skip signals used internally by libc, so
anything between 32 and SIGRTMIN. It's pretty safe to hardcode the first
value to 32 since that is the number of signals allocated by kernel
which is not going to change.
I guess that we can add something as SIGRTMIN_KERN or SIGRTMIN_BASE and
define it to 32 in some LTP header instead of hardcoding 32 into
testcases, which would be way better than misusing glibc internal
__SIGRTMIN.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-04-25 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 9:21 [LTP] [PATCH] sighold02: Fix muslc builds by removing __SIGRTMIN Richard Palethorpe via ltp
2022-04-25 9:35 ` Cyril Hrubis
2022-04-25 11:08 ` Petr Vorel
2022-04-25 11:09 ` Petr Vorel
2022-04-25 11:23 ` Cyril Hrubis [this message]
2022-04-27 7:57 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmaEmnRY9CNL9+Bu@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox