From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C5B9C433EF for ; Mon, 25 Apr 2022 12:39:19 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B038B3C90DA for ; Mon, 25 Apr 2022 14:39:16 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id CA9FF3C2EB0 for ; Mon, 25 Apr 2022 14:39:06 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 41F4E10005B4 for ; Mon, 25 Apr 2022 14:39:05 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6EEF5210E1; Mon, 25 Apr 2022 12:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1650890345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pgifaZqPK9zFZq+XiNfyw2RXsRjWlmapodgwgUDjsHI=; b=EY4crUt3xtv6r7ixZszolD9i9l5Blx6LMy+Z8OVVor2jU7lRxkTfPp7n9fPTr/7sRUENRQ KaNkJmtnN0pM/D2rFFHFxRrQe4Mk4UjD18v8wEgBnFeKqhH3DJWCElgv2lvXpf6EWpWwZC 90x1Kin/D595pgjGyXc6u1rnJYzoRBc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1650890345; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pgifaZqPK9zFZq+XiNfyw2RXsRjWlmapodgwgUDjsHI=; b=7DY1kUY6WqIA5GM5HD0vjEUCwDi0hxDIdofLsT0XbyxmW2Uj7EzDjcQnzdvfhvVuZsUYKM EswcU5BgeMCyHNDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4DADA13AED; Mon, 25 Apr 2022 12:39:05 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pz3HEWmWZmKqcQAAMHmgww (envelope-from ); Mon, 25 Apr 2022 12:39:05 +0000 Date: Mon, 25 Apr 2022 14:38:38 +0200 From: Cyril Hrubis To: Petr Vorel Message-ID: References: <20220406193650.15653-1-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220406193650.15653-1-pvorel@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [RFC PATCH 1/1] Remove syslog shell tests X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! These tests are meant to test mostly the syslog daemon rather than the syslog() syscall. I agree that such tests should be part of the respective syslog implementations and should be removed from LTP. Reviewed-by: Cyril Hrubis Also looking at man 2 syslog our coverage is lacking, so instead of keeping the shell test alive we should rather write a few more tests for the syslog(2) syscall. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp