Re: [LTP] [PATCH v4] syscalls/mount_setattr01: Add basic functional test

[Petr Vorel <pvorel@suse.cz>]

Hi all,

> > +/*\
> > + * [Description]
> > + *
> > + * Basic mount_setattr() test.
> > + * Test whether the basic mount attributes are set correctly.
> > + *
> > + * Verify some MOUNT_SETATTR(2) attributes:
> > + *
> > + * - 1) MOUNT_ATTR_RDONLY - makes the mount read-only
> > + * - 2) MOUNT_ATTR_NOSUID - causes the mount not to honor the
> > + *     set-user-ID and set-group-ID mode bits and file capabilities
> > + *     when executing programs.
> > + * - 3) MOUNT_ATTR_NODEV - prevents access to devices on this mount
> > + * - 4) MOUNT_ATTR_NOEXEC - prevents executing programs on this mount
> > + * - 5) MOUNT_ATTR_NOSYMFOLLOW - prevents following symbolic links
> > + *    on this mount
> > + * - 6) MOUNT_ATTR_NODIRATIME - prevents updating access time for
> > + *    directories on this mount

> The numbers here are useless and confusing I bet that it renders
> strangely in asciidoc too.

+1. Simple bullets done with "-" are good enough.
Some people used numbers in our docs, but I don't think it's necessary and I'd
be for removing it.

BTW if we want to use it, it'd have to be with dot (i.e. 1.).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp