From: Petr Vorel <pvorel@suse.cz>
To: Chen Hanxiao <chenhx.fnst@fujitsu.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5] syscalls/mount_setattr01: Add basic functional test
Date: Thu, 28 Apr 2022 14:24:20 +0200 [thread overview]
Message-ID: <YmqHdHHNSR+d4SLy@pevik> (raw)
In-Reply-To: <20220428104642.110-1-chenhx.fnst@fujitsu.com>
Hi Dai, Chen,
Reviewed-by: Petr Vorel <pvorel@suse.cz>
LGTM, waiting for Cyril's final ack before merging.
> diff --git a/testcases/kernel/syscalls/mount_setattr/mount_setattr01.c b/testcases/kernel/syscalls/mount_setattr/mount_setattr01.c
...
> +#define MNTPOINT "mntpoint"
> +#define OT_MNTPOINT "ot_mntpoint"
> +#define TCASE_ENTRY(attrs, exp_attrs) \
> + { \
> + .name = #attrs, \
> + .mount_attrs = attrs, \
> + .expect_attrs = exp_attrs \
> + }
nit: This is absolutely ok, but I'd personally use the version from v2, which
set only .name and .mount_attrs (the only point for macros are to reduce
duplicity, which is not in passing .expect_attrs).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-04-28 12:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 10:46 [LTP] [PATCH v5] syscalls/mount_setattr01: Add basic functional test Chen Hanxiao
2022-04-28 12:24 ` Petr Vorel [this message]
2022-05-09 9:37 ` [LTP] 回复: " chenhx.fnst
2022-05-18 8:50 ` [LTP] " Petr Vorel
2022-05-18 14:16 ` xuyang2018.jy
2022-05-18 15:42 ` Petr Vorel
2022-05-27 10:36 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmqHdHHNSR+d4SLy@pevik \
--to=pvorel@suse.cz \
--cc=chenhx.fnst@fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox