From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] smoketest: Add macsec02.sh
Date: Tue, 10 May 2022 07:45:17 +0200 [thread overview]
Message-ID: <Ynn77amLZR/Scql4@pevik> (raw)
In-Reply-To: <YnkzFzxszzAo26Oc@yuki>
Hi Cyril,
> Hi!
> > macsec02.sh is a network tests which uses macsec_lib.sh, which uses
> > ipsec_lib.sh and virt_lib.sh which use tst_net.sh.
> > Adding this test to smoketest to cover functionality of nested
> > libraries. Use macsec02.sh as it requires more setup (unlike macsec01.sh).
> I'm not 100% sure how big should the smoketest be. I guess adding this
> will be still fine, but we should stop adding new tests in there after a
> while, it's supposed to be small and fast.
Understand. I'd still prefer to test macsec02.sh, which uses ipsec_lib.sh,
virt_lib.sh, tst_net.sh and tst_test.sh via macsec_lib.sh.
How about replacing "ping01 ping01.sh" with it?
Because there still would be "ping602 ping02.sh -6".
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-05-10 5:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 10:44 [LTP] [PATCH 1/1] smoketest: Add macsec02.sh Petr Vorel
2022-05-09 15:28 ` Cyril Hrubis
2022-05-10 5:45 ` Petr Vorel [this message]
2022-05-17 11:42 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ynn77amLZR/Scql4@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox