[LTP] [PATCH 1/1] smoketest: Add macsec02.sh

[LTP] [PATCH 1/1] smoketest: Add macsec02.sh

[Petr Vorel]

macsec02.sh is a network tests which uses macsec_lib.sh, which uses
ipsec_lib.sh and virt_lib.sh which use tst_net.sh.

Adding this test to smoketest to cover functionality of nested
libraries. Use macsec02.sh as it requires more setup (unlike macsec01.sh).

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 runtest/smoketest | 1 +
 1 file changed, 1 insertion(+)

diff --git a/runtest/smoketest b/runtest/smoketest
index 7bebe4a42e..b7c539640b 100644
--- a/runtest/smoketest
+++ b/runtest/smoketest
@@ -15,3 +15,4 @@ splice02 splice02 -s 20
 shell_test01 echo "SUCCESS" | shell_pipe01.sh
 ping01 ping01.sh
 ping602 ping02.sh -6
+macsec02 macsec02.sh
-- 
2.35.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] smoketest: Add macsec02.sh

[Cyril Hrubis]

Hi!
> macsec02.sh is a network tests which uses macsec_lib.sh, which uses
> ipsec_lib.sh and virt_lib.sh which use tst_net.sh.
> 
> Adding this test to smoketest to cover functionality of nested
> libraries. Use macsec02.sh as it requires more setup (unlike macsec01.sh).

I'm not 100% sure how big should the smoketest be. I guess adding this
will be still fine, but we should stop adding new tests in there after a
while, it's supposed to be small and fast.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] smoketest: Add macsec02.sh

[Petr Vorel]

Hi Cyril,

> Hi!
> > macsec02.sh is a network tests which uses macsec_lib.sh, which uses
> > ipsec_lib.sh and virt_lib.sh which use tst_net.sh.

> > Adding this test to smoketest to cover functionality of nested
> > libraries. Use macsec02.sh as it requires more setup (unlike macsec01.sh).

> I'm not 100% sure how big should the smoketest be. I guess adding this
> will be still fine, but we should stop adding new tests in there after a
> while, it's supposed to be small and fast.
Understand. I'd still prefer to test macsec02.sh, which uses ipsec_lib.sh,
virt_lib.sh, tst_net.sh and tst_test.sh via macsec_lib.sh.
How about replacing "ping01 ping01.sh" with it?

Because there still would be "ping602 ping02.sh -6".

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] smoketest: Add macsec02.sh

[Petr Vorel]

Hi all,

> macsec02.sh is a network tests which uses macsec_lib.sh, which uses
> ipsec_lib.sh and virt_lib.sh which use tst_net.sh.

> Adding this test to smoketest to cover functionality of nested
> libraries. Use macsec02.sh as it requires more setup (unlike macsec01.sh).

I merged this one, replacing ping01.sh, to keep number of the tests the same.
NOTE: Although it's a performance test unlike other tests in net.features
macsec02.sh is very stable (looked for results for 4 architectures). In case
anybody complains about the stability we can always revert
be1888a9e ("smoketest: Add macsec02.sh, remove ping01.sh")

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp