Re: [LTP] [PATCH v5] syscalls/mount_setattr01: Add basic functional test

Petr Vorel
2022-05-18T15:42:56Z

Hi Xu, all,

> > Thus I suggest to have this cleanup code:

> > out1:
> > SAFE_CLOSE(otfd);
> > out2:
> > if (mount_flag)
> > SAFE_UMOUNT(OT_MNTPOINT);

> > mount_flag = 0;

> > If Cyril is ok with this I'd merge it before release.
> > (I tested it on various systems, found only this issue.)
> This fix is obviously correct. Since I have reviewed this patch in
> internal, you can also add my reviewed-by for this patch.

Adding it (I'm lazy thus want patchwork to take this patch.
Reviewed-by: Yang Xu <xuyang2018.jy@fujitsu.com>

> ps: I think we should also check functionality like mount03 did instead
> of just check flag.
+1. Although test_rwflag() is a bit complex.

Kind regards,
Petr

> Best Regards
> Yang Xu