[LTP] 回复: [PATCH v5] syscalls/mount_setattr01: Add basic functional test

chenhx.fnst
2022-05-09T09:38:07Z

> -----邮件原件-----
> 发件人: Petr Vorel <pvorel@suse.cz>
> 发送时间: 2022年4月28日 20:24
> <daisl.fnst@fujitsu.com>
> 主题: Re: [PATCH v5] syscalls/mount_setattr01: Add basic functional test
>
> Hi Dai, Chen,
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz> LGTM, waiting for Cyril's final ack
> before merging.

Hi, Cyril

Any comments?

Regards,
- Chen

>
> > diff --git a/testcases/kernel/syscalls/mount_setattr/mount_setattr01.c
> > b/testcases/kernel/syscalls/mount_setattr/mount_setattr01.c
> ...
> > +#define MNTPOINT "mntpoint"
> > +#define OT_MNTPOINT "ot_mntpoint"
> > +#define TCASE_ENTRY(attrs, exp_attrs) \
> > + { \
> > + .name = #attrs, \
> > + .mount_attrs = attrs, \
> > + .expect_attrs = exp_attrs \
> > + }
> nit: This is absolutely ok, but I'd personally use the version from v2, which set
> only .name and .mount_attrs (the only point for macros are to reduce duplicity,
> which is not in passing .expect_attrs).
>
> Kind regards,
> Petr