From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Fix ltp-aiodio tests failing on s390
Date: Fri, 20 May 2022 09:30:43 +0200 [thread overview]
Message-ID: <YodDo1PKnlGhTNgv@pevik> (raw)
In-Reply-To: <20220519174151.14114-1-andrea.cervesato@suse.de>
Hi Andrea,
> --- a/testcases/kernel/io/ltp-aiodio/dio_append.c
> +++ b/testcases/kernel/io/ltp-aiodio/dio_append.c
> @@ -19,7 +19,7 @@
> #include "tst_test.h"
> #include "common.h"
> -static int *run_child;
> +static volatile int *run_child;
> static char *str_numchildren;
> static char *str_writesize;
> @@ -49,7 +49,10 @@ static void setup(void)
> static void cleanup(void)
> {
> - SAFE_MUNMAP(run_child, sizeof(int));
> + if (run_child) {
> + *run_child = 0;
> + SAFE_MUNMAP((void *)run_child, sizeof(int));
> + }
nit: This looks like unrelated, right? If yes it could be in separate commit.
But I'm ok to merge it in single commit.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-05-20 7:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 17:41 [LTP] [PATCH v1] Fix ltp-aiodio tests failing on s390 Andrea Cervesato
2022-05-20 7:30 ` Petr Vorel [this message]
2022-05-20 8:10 ` Andrea Cervesato via ltp
2022-05-20 9:19 ` Cyril Hrubis
2022-05-20 12:01 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2022-05-19 13:12 Andrea Cervesato via ltp
2022-05-19 14:00 ` Cyril Hrubis
2022-05-19 12:19 Andrea Cervesato via ltp
2022-05-19 12:54 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YodDo1PKnlGhTNgv@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox