From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 2/2] pty04: Fix cleanup
Date: Fri, 20 May 2022 11:13:10 +0200 [thread overview]
Message-ID: <YodbppwrK3MfbyFX@pevik> (raw)
In-Reply-To: <10ee5852-9302-22d7-832c-f581ef94c336@suse.cz>
> On 20. 05. 22 11:01, Petr Vorel wrote:
> > BTW C API would deserve (after the release) TBROK on -i0, which is already
> > implemented in shell API:
> > df01 1 TBROK: Number of iterations (-i) must be > 0
> I don't see why. Running pty07 with -i0 was actually quite helpful in
> debugging this issue. If a test fails when executed with -i0, it needs
> to be fixed.
Do you mean that -i0 is useful to test only setup and cleanup in C API?
If we agree we want this (not against it if it's useful), shell API should
be unified with it (my concern was that both APIs should behave the same on
the same getopt option).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-05-20 9:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 12:10 [LTP] [PATCH 1/2] pty07: Resize console to the same size as before Martin Doucha
2022-05-19 12:10 ` [LTP] [PATCH 2/2] pty04: Fix cleanup Martin Doucha
2022-05-20 9:01 ` Petr Vorel
2022-05-20 9:08 ` Martin Doucha
2022-05-20 9:13 ` Petr Vorel [this message]
2022-05-20 9:21 ` Cyril Hrubis
2022-05-20 11:30 ` Petr Vorel
2022-05-20 9:22 ` Cyril Hrubis
2022-05-20 11:55 ` Petr Vorel
2022-05-20 9:05 ` [LTP] [PATCH 1/2] pty07: Resize console to the same size as before Petr Vorel
2022-05-20 9:26 ` Cyril Hrubis
2022-05-20 9:33 ` Martin Doucha
2022-05-20 11:50 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YodbppwrK3MfbyFX@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=mdoucha@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox