From: Petr Vorel <pvorel@suse.cz>
To: Zhao Gongyi <zhaogongyi@huawei.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] tst_kvercmp.sh: strip '+' when $(EXTRAVERSION) is blank
Date: Mon, 6 Jun 2022 20:53:13 +0200 [thread overview]
Message-ID: <Yp5NGYJpah3d/uBh@pevik> (raw)
In-Reply-To: <20220606113649.41600-1-zhaogongyi@huawei.com>
Hi Zhao,
> $(EXTRAVERSION) defines an even tinier sublevel for pre-patches
> or additional patches. It is usually some non-numeric string
> such as "-pre4", and is often blank. When $(EXTRAVERSION) is blank,
> there may be a extra '+' which shoud be stripped.
...
> r3=${r3%%-*}
> +r3=${r3%%+*}
Is that '+' on kernel which sources were modified without commit?
This can be on version with non-blank EXTRAVERSION, but in that case it's
already removed by r3=${r3%%-*}, right?
LGTM
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-06-06 18:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 11:36 [LTP] [PATCH] tst_kvercmp.sh: strip '+' when $(EXTRAVERSION) is blank Zhao Gongyi via ltp
2022-06-06 18:53 ` Petr Vorel [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-06-07 2:14 zhaogongyi via ltp
2022-06-07 15:04 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp5NGYJpah3d/uBh@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=zhaogongyi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox