From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/2] lib: extend .request_hugepages to guarantee enough hpages
Date: Mon, 6 Jun 2022 22:33:07 +0200 [thread overview]
Message-ID: <Yp5kg2W62o/FpR4G@pevik> (raw)
In-Reply-To: <Yp5hlrqtwtE0r4Bj@pevik>
Hi Li,
> > diff --git a/lib/newlib_tests/test_zero_hugepage.c b/lib/newlib_tests/test_zero_hugepage.c
> ...
> > static struct tst_test test = {
> > .test_all = do_test,
> > - .request_hugepages = TST_NO_HUGEPAGES,
> > + .hugepages = {TST_NO_HUGEPAGES},
> Also comment at the top should be renamed:
> -Tests .request_hugepages = TST_NO_HUGEPAGES
> +Tests .hugepages = {TST_NO_HUGEPAGES}
Except this very minor issue LGTM. Thanks!
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-06-06 20:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 10:00 [LTP] [PATCH v3 0/2] extend .request_hugepages Li Wang
2022-06-06 10:00 ` [LTP] [PATCH v3 1/2] lib: extend .request_hugepages to guarantee enough hpages Li Wang
2022-06-06 20:20 ` Petr Vorel
2022-06-06 20:33 ` Petr Vorel [this message]
2022-06-06 10:00 ` [LTP] [PATCH v3 2/2] memfd_create03: make use of new .hugepages Li Wang
2022-06-06 20:31 ` Petr Vorel
2022-06-07 3:08 ` Li Wang
2022-06-07 9:28 ` Cyril Hrubis
2022-06-07 9:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp5kg2W62o/FpR4G@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox