From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC7ACC43334 for ; Mon, 6 Jun 2022 20:33:25 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 9D9E83C8CE0 for ; Mon, 6 Jun 2022 22:33:23 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [IPv6:2001:4b78:1:20::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id CED643C051B for ; Mon, 6 Jun 2022 22:33:13 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id CAC8E6002D4 for ; Mon, 6 Jun 2022 22:33:12 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D772A1F45B; Mon, 6 Jun 2022 20:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1654547591; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CfUBQ6IrTStAHlxEkhuvPRkMC2bsC5udvWZ5n2olO4o=; b=Otj/Fjy8DHGoWQIJZr8QSJuRNu97IYmwy2axrB0Q1L1bHYrMIT1yroG3QKGoL0Tw8HS6A3 eELhNz7PhmsCgEKBZvdOOSTwVhO2TSblDDRa463jC8dyyZ5lAnGH+B075YgbGAJB5GBr9/ 9DCzM/Kpi5vFLydXwNCM6oa9+lBeM/0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1654547591; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CfUBQ6IrTStAHlxEkhuvPRkMC2bsC5udvWZ5n2olO4o=; b=8O8aBQfS7TbST7HS8HehxPMcOejlw5M9/XxKqp5lbptLaFN10JH/1GDaaIpJOmP4KmvTQ/ D5ujj/NE+8hj7ICQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6E48513A5F; Mon, 6 Jun 2022 20:33:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 0ZRREodknmL8TwAAMHmgww (envelope-from ); Mon, 06 Jun 2022 20:33:11 +0000 Date: Mon, 6 Jun 2022 22:33:07 +0200 From: Petr Vorel To: Li Wang , ltp@lists.linux.it Message-ID: References: <20220606100034.169493-1-liwang@redhat.com> <20220606100034.169493-2-liwang@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v3 1/2] lib: extend .request_hugepages to guarantee enough hpages X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Li, > > diff --git a/lib/newlib_tests/test_zero_hugepage.c b/lib/newlib_tests/test_zero_hugepage.c > ... > > static struct tst_test test = { > > .test_all = do_test, > > - .request_hugepages = TST_NO_HUGEPAGES, > > + .hugepages = {TST_NO_HUGEPAGES}, > Also comment at the top should be renamed: > -Tests .request_hugepages = TST_NO_HUGEPAGES > +Tests .hugepages = {TST_NO_HUGEPAGES} Except this very minor issue LGTM. Thanks! Reviewed-by: Petr Vorel Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp