From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: Martin Doucha <martin.doucha@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 3/8] tst_test.sh: Improve pattern for allowed variables
Date: Mon, 30 May 2022 16:21:43 +0200 [thread overview]
Message-ID: <YpTS99QLyFfSkrnl@rei> (raw)
In-Reply-To: <20220512194557.30911-4-pvorel@suse.cz>
Hi!
> if [ -n "$TST_TEST_PATH" ]; then
> - for _tst_i in $(grep '^[^#]*\bTST_' "$TST_TEST_PATH" | sed 's/.*TST_//; s/[="} \t\/:`].*//'); do
> + for _tst_i in $(grep '^[^#]*\bTST_' "$TST_TEST_PATH" | sed 's/.*TST_//; s/[="} \t\/:`'"'"'].*//'); do
^
Isn't
the
content
between
[]
just
set?
Shouldn't adding just ' between the [] suffice? The " is already there.
> case "$_tst_i" in
> DISABLE_APPARMOR|DISABLE_SELINUX);;
> SETUP|CLEANUP|TESTFUNC|ID|CNT|MIN_KVER);;
> --
> 2.36.0
>
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-05-30 14:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 19:45 [LTP] [PATCH 0/8] shell: $TST_ALL_FILESYSTEMS (.all_filesystems) Petr Vorel
2022-05-12 19:45 ` [LTP] [PATCH 1/8] tst_test.sh: Add $TST_MOUNT_DEVICE Petr Vorel
2022-05-30 14:04 ` Cyril Hrubis
2022-06-01 6:38 ` Petr Vorel
2022-05-12 19:45 ` [LTP] [PATCH 2/8] df01.sh: Use TST_MOUNT_DEVICE=1 Petr Vorel
2022-05-30 14:13 ` Cyril Hrubis
2022-05-12 19:45 ` [LTP] [PATCH 3/8] tst_test.sh: Improve pattern for allowed variables Petr Vorel
2022-05-30 14:21 ` Cyril Hrubis [this message]
2022-06-03 12:24 ` Petr Vorel
2022-06-03 13:23 ` Cyril Hrubis
2022-06-03 18:44 ` Petr Vorel
2022-05-12 19:45 ` [LTP] [PATCH 4/8] shell: Add test for TST_MOUNT_DEVICE=1 Petr Vorel
2022-05-30 15:05 ` Cyril Hrubis
2022-05-12 19:45 ` [LTP] [PATCH 5/8] shell: Add tst_clear_device Petr Vorel
2022-05-30 15:12 ` Cyril Hrubis
2022-06-01 10:34 ` Petr Vorel
2022-06-01 11:22 ` Cyril Hrubis
2022-06-01 13:17 ` Petr Vorel
2022-06-01 10:37 ` Petr Vorel
2022-05-12 19:45 ` [LTP] [PATCH 6/8] tst_test.sh: Add $TST_ALL_FILESYSTEMS Petr Vorel
2022-05-31 12:25 ` Cyril Hrubis
2022-06-01 8:41 ` Petr Vorel
2022-05-12 19:45 ` [LTP] [PATCH 7/8] shell: Add test for TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-05-13 8:17 ` Petr Vorel
2022-05-31 12:43 ` Cyril Hrubis
2022-05-12 19:45 ` [LTP] [PATCH 8/8] nfs07.sh: Use TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-05-13 9:08 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpTS99QLyFfSkrnl@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=martin.doucha@suse.com \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox