From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/execve06: Add test for argv[0] = NULL
Date: Mon, 13 Jun 2022 15:51:20 +0200 [thread overview]
Message-ID: <YqdA2P+NCeGKdB5q@pevik> (raw)
In-Reply-To: <20220613125153.20423-1-chrubis@suse.cz>
HI Cyril,
> Adds a test that kernel sets argv[0] to a dummy empty string if NULL was
> passed to the execve() syscall. This was introduced in commit:
> commit dcd46d897adb70d63e025f175a00a89797d31a43
> Author: Kees Cook <keescook@chromium.org>
> Date: Mon Jan 31 16:09:47 2022 -0800
> exec: Force single empty string when argv is empty
> in order to fix all potential CVEs where userspace programs attempt to
> blindly process the argv[] list starting at argv[1]. There was at least
> one example of this caught in the wild CVE-2021-4034 in polkit but there
> are likely more.
Great, thanks for addressing this.
> Fixes: #911
> testcases/kernel/syscalls/execve/.gitignore | 2 +
> testcases/kernel/syscalls/execve/execve06.c | 49 +++++++++++++++++++
> .../kernel/syscalls/execve/execve06_child.c | 27 ++++++++++
> 3 files changed, 78 insertions(+)
> create mode 100644 testcases/kernel/syscalls/execve/execve06.c
> create mode 100644 testcases/kernel/syscalls/execve/execve06_child.c
This should go to runtest/syscalls and runtest/cve, right?
(can be fixed before merge).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-06-13 13:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 12:51 [LTP] [PATCH] syscalls/execve06: Add test for argv[0] = NULL Cyril Hrubis
2022-06-13 13:51 ` Petr Vorel [this message]
2022-06-14 12:17 ` Cyril Hrubis
2022-06-13 14:31 ` Petr Vorel
2022-06-14 13:04 ` Cyril Hrubis
2022-06-14 13:34 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqdA2P+NCeGKdB5q@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox