From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: linux-nfs@vger.kernel.org, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 5/9] tst_test.sh: Add $TST_ALL_FILESYSTEMS
Date: Fri, 17 Jun 2022 16:07:55 +0200 [thread overview]
Message-ID: <YqyKu2Gi7SbeplMs@pevik> (raw)
In-Reply-To: <YqyHNFkJdC0q2Vxs@yuki>
Hi Cyril,
> Generally the code looks good, there is still a minor difference between
> C API and this changes though. As we do call the _tst_cleanup_timer at
> the end of this function the script runs without a timeout for a short
> while (which includes tst_mkfs call).
> I guess that instead of stopping the timer at the end of the
> _tst_run_iterations() we can simply reset it (on the top of this patch):
Good catch, thanks for providing a patch.
LGTM, I'll have a deeper look later.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-06-17 14:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 21:42 [LTP] [PATCH 0/9] shell: nfs: $TST_ALL_FILESYSTEMS (.all_filesystems) Petr Vorel
2022-06-09 21:42 ` [LTP] [PATCH v2 1/9] tst_test.sh: Add $TST_MOUNT_DEVICE Petr Vorel
2022-06-09 21:42 ` [LTP] [PATCH v2 2/9] df01.sh: Use TST_MOUNT_DEVICE=1 Petr Vorel
2022-06-09 21:42 ` [LTP] [PATCH v2 3/9] tst_test.sh: allow ' in pattern for allowed variables Petr Vorel
2022-06-17 11:59 ` Cyril Hrubis
2022-06-09 21:42 ` [LTP] [PATCH v2 4/9] shell: Add test for TST_MOUNT_DEVICE=1 Petr Vorel
2022-07-11 15:02 ` Petr Vorel
2022-06-09 21:42 ` [LTP] [PATCH v2 5/9] tst_test.sh: Add $TST_ALL_FILESYSTEMS Petr Vorel
2022-06-17 13:52 ` Cyril Hrubis
2022-06-17 14:07 ` Petr Vorel [this message]
2022-08-04 7:07 ` Petr Vorel
2022-06-09 21:42 ` [LTP] [PATCH v2 6/9] tst_device: Remove unnecessary braces Petr Vorel
2022-06-17 13:57 ` Cyril Hrubis
2022-06-09 21:42 ` [LTP] [PATCH v2 7/9] tst_device: Add clear command Petr Vorel
2022-06-17 14:02 ` Cyril Hrubis
2022-06-09 21:42 ` [LTP] [PATCH v2 8/9] shell: Add test for TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-06-16 5:59 ` Li Wang
2022-06-09 21:42 ` [LTP] [RFC][PATCH v2 9/9] nfs: Use TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-06-16 6:11 ` Li Wang
2022-06-16 6:51 ` Petr Vorel
2022-06-17 14:51 ` Cyril Hrubis
2022-07-11 15:08 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqyKu2Gi7SbeplMs@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=linux-nfs@vger.kernel.org \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox