From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [COMMITTED][PATCH 1/1] nfs05_make_tree: Restore 5 min timeout
Date: Fri, 17 Jun 2022 17:09:09 +0200 [thread overview]
Message-ID: <YqyZFXpsGsJvsHGn@yuki> (raw)
In-Reply-To: <YqyDtBC3++fGQGdp@pevik>
Hi!
> > I guess that it would probably implement main() in the nfs05_make_tree.c
> > instead as we do for the various tools in testcases/lib/*.c. That would
> > at least make sure that we will not break anything with changes intended
> > for tests and not for helper binaries as this one.
>
> Helper binaries does not use LTP C API. I'd like to keep it (to have SAFE_*()),
> I guess you're not against. Therefore just using TST_NO_DEFAULT_MAIN
> and adding main(), right?
I guess that would work, but I will have to double check the tst_test.c
library.
Also I'm not sure that this would be the best solution, mixing C and
shell code was always akward and maybe we can figure out how to make it
better.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-06-17 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 16:23 [LTP] [COMMITTED][PATCH 1/1] nfs05_make_tree: Restore 5 min timeout Petr Vorel
2022-06-17 9:13 ` Cyril Hrubis
2022-06-17 13:37 ` Petr Vorel
2022-06-17 15:09 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqyZFXpsGsJvsHGn@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox