From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C11FEC00144 for ; Thu, 4 Aug 2022 07:08:01 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 0A4803C93DF for ; Thu, 4 Aug 2022 09:07:59 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 1EAEF3C5AA6 for ; Thu, 4 Aug 2022 09:07:49 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id E97396007AF for ; Thu, 4 Aug 2022 09:07:48 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 95E2620B5A; Thu, 4 Aug 2022 07:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1659596867; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YvFr4zTnt14JlVaUqO+3d/Sncgi9+1A8eOOSBpbi6RU=; b=uEWG+KPBqEqe8SBCMgZtVrao3zdY+nfAfGtYEVJ6/ghSymw912/5iXqVb+yIaZUPUjBa3x Ba6RrIqvCZfz5zMRYUCmiD5AUui5K/qr+hEcHfJdS/oTjzwx9mOB3lYRzz/T3xwZhddAS1 sRqPzZLwH2AP32Lx67i1e0swUd0sekg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1659596867; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YvFr4zTnt14JlVaUqO+3d/Sncgi9+1A8eOOSBpbi6RU=; b=eWBlfeSYCqDperXUA3ykYOBEf1XrRzAJ9V41gC1myl3Qz1+CY9Ma6SG00evcylfN64UT2k Eu4YEe0VIAytW/Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3F8F51348A; Thu, 4 Aug 2022 07:07:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YKEbDUNw62KJDgAAMHmgww (envelope-from ); Thu, 04 Aug 2022 07:07:47 +0000 Date: Thu, 4 Aug 2022 09:07:45 +0200 From: Petr Vorel To: ltp@lists.linux.it Message-ID: References: <20220609214223.4608-1-pvorel@suse.cz> <20220609214223.4608-6-pvorel@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220609214223.4608-6-pvorel@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 5/9] tst_test.sh: Add $TST_ALL_FILESYSTEMS X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: linux-nfs@vger.kernel.org, Martin Doucha Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi all, I wonder if we want to sort filesystems: -for _tst_fs in $(tst_supported_fs); do +for _tst_fs in $(tst_supported_fs | sort); do or even -u (as uniq). Martin used it in testcases/misc/lvm/prepare_lvm.sh, but IMHO it should not be needed: looping over fs_type_whitelist() should be always the same. FS_LIST=`tst_supported_fs | sort -u` Therefore I'd remove it (don't use unnecessary dependencies - be nice for people with minimal environment): Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp