Re: [LTP] [PATCH v2 1/2] tst_device: Increase DEV_MIN_SIZE to 300 MB

[Petr Vorel <pvorel@suse.cz>]

> Hi!
> > > Previous default 256 MB was not enough for mkfs.xfs since v5.19.0-rc1
> > > [1] which refuses to create filesystems < 300 MB. Although the
> > > limitation can be workarounded by setting three environment variables,
> > > it's better to increase the variable.

> > > [1]: https://lore.kernel.org/all/164738662491.3191861.15611882856331908607.stgit@magnolia/

> > > Reported-by: Martin Doucha <mdoucha@suse.cz>
> > > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > > ---
> > >  lib/tst_device.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > diff --git a/lib/tst_device.c b/lib/tst_device.c
> > > index c34cbe6d1..8419b80c3 100644
> > > --- a/lib/tst_device.c
> > > +++ b/lib/tst_device.c
> > > @@ -44,7 +44,7 @@
> > >  #define LOOP_CONTROL_FILE "/dev/loop-control"

> > >  #define DEV_FILE "test_dev.img"
> > > -#define DEV_SIZE_MB 256u
> > > +#define DEV_SIZE_MB 300u

> > Subject is wrong - it is saying DEV_MIN_SIZE

> > It really looks weird that DEV_SIZE_MB < DEV_MIN_SIZE
> > What am I missing?

> The DEV_MIN_SIZE macro is used in a LTP test library API test that
> checks that test can override minial device size so it has to be greater
> than DEV_SIZE_MB which is the size used by the test library when
> loopback devices are created.
Tests in lib/newlib_tests/ are tests which test the LTP itself,
maybe use some prefix for these constants would make obvious that it's not part
of the library (i.e. not visible in normal LTP tests).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp