[LTP] [PATCH v2 0/2] Fix mkfs.xfs 300MB min size requirement (v5.19.0)

[LTP] [PATCH v2 0/2] Fix mkfs.xfs 300MB min size requirement (v5.19.0)

[Petr Vorel]

Changes v1->v2:
* bump min size to 300 MB instead using workaround (export TEST_DIR=1
  TEST_DEV=1 QA_CHECK_FS=1)
* increase test for .dev_min_size (so that we don't test for the default
  value)

Kind regards,
Petr

Petr Vorel (2):
  tst_device: Increase DEV_MIN_SIZE to 300 MB
  lib/tests: Increase .dev_min_size

 lib/newlib_tests/tst_device.c | 2 +-
 lib/tst_device.c              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.37.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v2 1/2] tst_device: Increase DEV_MIN_SIZE to 300 MB

[Petr Vorel]

Previous default 256 MB was not enough for mkfs.xfs since v5.19.0-rc1
[1] which refuses to create filesystems < 300 MB. Although the
limitation can be workarounded by setting three environment variables,
it's better to increase the variable.

[1]: https://lore.kernel.org/all/164738662491.3191861.15611882856331908607.stgit@magnolia/

Reported-by: Martin Doucha <mdoucha@suse.cz>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 lib/tst_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/tst_device.c b/lib/tst_device.c
index c34cbe6d1..8419b80c3 100644
--- a/lib/tst_device.c
+++ b/lib/tst_device.c
@@ -44,7 +44,7 @@
 #define LOOP_CONTROL_FILE "/dev/loop-control"
 
 #define DEV_FILE "test_dev.img"
-#define DEV_SIZE_MB 256u
+#define DEV_SIZE_MB 300u
 
 static char dev_path[1024];
 static int device_acquired;
-- 
2.37.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 1/2] tst_device: Increase DEV_MIN_SIZE to 300 MB

[Amir Goldstein]

On Thu, Aug 18, 2022 at 1:10 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> Previous default 256 MB was not enough for mkfs.xfs since v5.19.0-rc1
> [1] which refuses to create filesystems < 300 MB. Although the
> limitation can be workarounded by setting three environment variables,
> it's better to increase the variable.
>
> [1]: https://lore.kernel.org/all/164738662491.3191861.15611882856331908607.stgit@magnolia/
>
> Reported-by: Martin Doucha <mdoucha@suse.cz>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  lib/tst_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/tst_device.c b/lib/tst_device.c
> index c34cbe6d1..8419b80c3 100644
> --- a/lib/tst_device.c
> +++ b/lib/tst_device.c
> @@ -44,7 +44,7 @@
>  #define LOOP_CONTROL_FILE "/dev/loop-control"
>
>  #define DEV_FILE "test_dev.img"
> -#define DEV_SIZE_MB 256u
> +#define DEV_SIZE_MB 300u

Subject is wrong - it is saying DEV_MIN_SIZE

It really looks weird that DEV_SIZE_MB < DEV_MIN_SIZE
What am I missing?

Thanks,
Amir.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 1/2] tst_device: Increase DEV_MIN_SIZE to 300 MB

[Cyril Hrubis]

Hi!
> > Previous default 256 MB was not enough for mkfs.xfs since v5.19.0-rc1
> > [1] which refuses to create filesystems < 300 MB. Although the
> > limitation can be workarounded by setting three environment variables,
> > it's better to increase the variable.
> >
> > [1]: https://lore.kernel.org/all/164738662491.3191861.15611882856331908607.stgit@magnolia/
> >
> > Reported-by: Martin Doucha <mdoucha@suse.cz>
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> >  lib/tst_device.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/tst_device.c b/lib/tst_device.c
> > index c34cbe6d1..8419b80c3 100644
> > --- a/lib/tst_device.c
> > +++ b/lib/tst_device.c
> > @@ -44,7 +44,7 @@
> >  #define LOOP_CONTROL_FILE "/dev/loop-control"
> >
> >  #define DEV_FILE "test_dev.img"
> > -#define DEV_SIZE_MB 256u
> > +#define DEV_SIZE_MB 300u
> 
> Subject is wrong - it is saying DEV_MIN_SIZE
> 
> It really looks weird that DEV_SIZE_MB < DEV_MIN_SIZE
> What am I missing?

The DEV_MIN_SIZE macro is used in a LTP test library API test that
checks that test can override minial device size so it has to be greater
than DEV_SIZE_MB which is the size used by the test library when
loopback devices are created.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 1/2] tst_device: Increase DEV_MIN_SIZE to 300 MB

[Petr Vorel]

> Hi!
> > > Previous default 256 MB was not enough for mkfs.xfs since v5.19.0-rc1
> > > [1] which refuses to create filesystems < 300 MB. Although the
> > > limitation can be workarounded by setting three environment variables,
> > > it's better to increase the variable.

> > > [1]: https://lore.kernel.org/all/164738662491.3191861.15611882856331908607.stgit@magnolia/

> > > Reported-by: Martin Doucha <mdoucha@suse.cz>
> > > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > > ---
> > >  lib/tst_device.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)

> > > diff --git a/lib/tst_device.c b/lib/tst_device.c
> > > index c34cbe6d1..8419b80c3 100644
> > > --- a/lib/tst_device.c
> > > +++ b/lib/tst_device.c
> > > @@ -44,7 +44,7 @@
> > >  #define LOOP_CONTROL_FILE "/dev/loop-control"

> > >  #define DEV_FILE "test_dev.img"
> > > -#define DEV_SIZE_MB 256u
> > > +#define DEV_SIZE_MB 300u

> > Subject is wrong - it is saying DEV_MIN_SIZE

> > It really looks weird that DEV_SIZE_MB < DEV_MIN_SIZE
> > What am I missing?

> The DEV_MIN_SIZE macro is used in a LTP test library API test that
> checks that test can override minial device size so it has to be greater
> than DEV_SIZE_MB which is the size used by the test library when
> loopback devices are created.
Tests in lib/newlib_tests/ are tests which test the LTP itself,
maybe use some prefix for these constants would make obvious that it's not part
of the library (i.e. not visible in normal LTP tests).

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v2 2/2] lib/tests: Increase .dev_min_size

[Petr Vorel]

New LTP default for device size was increased to 300MB in previous
commit, which is the same as for test of .dev_min_size. Therefore
increase test of .dev_min_size to 310MB.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 lib/newlib_tests/tst_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/newlib_tests/tst_device.c b/lib/newlib_tests/tst_device.c
index 8ac1d14cc..87cec3961 100644
--- a/lib/newlib_tests/tst_device.c
+++ b/lib/newlib_tests/tst_device.c
@@ -15,7 +15,7 @@
 #include "tst_test.h"
 
 #define DEVBLOCKSIZE 2048
-#define DEV_MIN_SIZE 300
+#define DEV_MIN_SIZE 310
 
 static char *mntpoint;
 static uint64_t ltp_dev_size;
-- 
2.37.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 0/2] Fix mkfs.xfs 300MB min size requirement (v5.19.0)

[Petr Vorel]

Hi all,

> Changes v1->v2:
> * bump min size to 300 MB instead using workaround (export TEST_DIR=1
>   TEST_DEV=1 QA_CHECK_FS=1)
> * increase test for .dev_min_size (so that we don't test for the default
>   value)

Do we want to merge this patchset to get XFS fix before the release?
I'll finish tracking minimal filesystem size after the release.

Kind regards,
Petr

> Kind regards,
> Petr

> Petr Vorel (2):
>   tst_device: Increase DEV_MIN_SIZE to 300 MB
>   lib/tests: Increase .dev_min_size

>  lib/newlib_tests/tst_device.c | 2 +-
>  lib/tst_device.c              | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 0/2] Fix mkfs.xfs 300MB min size requirement (v5.19.0)

[Li Wang]

[-- Attachment #1.1: Type: text/plain, Size: 166 bytes --]

Hi Petr,


Do we want to merge this patchset to get XFS fix before the release?
>

Sure, I'm fine going with this temporary fix for releasing.


-- 
Regards,
Li Wang

[-- Attachment #1.2: Type: text/html, Size: 737 bytes --]

[-- Attachment #2: Type: text/plain, Size: 60 bytes --]


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 0/2] Fix mkfs.xfs 300MB min size requirement (v5.19.0)

[Cyril Hrubis]

Hi!
> Do we want to merge this patchset to get XFS fix before the release?
> >
> 
> Sure, I'm fine going with this temporary fix for releasing.

Same here.

Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 0/2] Fix mkfs.xfs 300MB min size requirement (v5.19.0)

[Petr Vorel]

> Hi!
> > Do we want to merge this patchset to get XFS fix before the release?


> > Sure, I'm fine going with this temporary fix for releasing.

> Same here.

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Thanks a lot both, patchset merged!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp