From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v5] Refactor aiocp using new LTP API
Date: Wed, 10 Aug 2022 08:57:20 +0200 [thread overview]
Message-ID: <YvNW0OQYwUhDjIOC@pevik> (raw)
In-Reply-To: <Yuz5pIv+98cFmgBg@yuki>
Hi Andrea, Cyril,
> Hi!
> The code looks good now, but still needs a runtime treatement similar to
> the one done in 3ab0b3cb24198a0a833e4450b8bc9cee8b70baf6.
OK, new version is needed. When you're in it, could you please consider things
Cyril asked in v1? [1]
* rename functions
I guess that it would be cleaner to rename the functions to something as
put_iocb() and get_iocb() since they do not allcate anything but they
have to stay.
* I suppose later you implement ioctl() BLKSZGET
> -static int dev_block_size_by_path(const char *path)
Just FYI this is actually the only correct way how to get the O_DIRECT
block size, we have to get the device and then call the BLKSZGET
ioctl(). This code has to be put into the test library and reused in all
O_DIRECT tests in a followup patch.
Kind regards,
Petr
[1] https://patchwork.ozlabs.org/comment/2917667/
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-08-10 6:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 12:09 [LTP] [PATCH v5] Refactor aiocp using new LTP API Andrea Cervesato via ltp
2022-08-03 17:23 ` Petr Vorel
2022-08-05 11:06 ` Cyril Hrubis
2022-08-10 6:57 ` Petr Vorel [this message]
2022-08-10 7:00 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvNW0OQYwUhDjIOC@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox