From: Cyril Hrubis <chrubis@suse.cz>
To: Edward Liaw <edliaw@google.com>
Cc: kernel-team@android.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] syscalls/signal06: add volatile to loop variable
Date: Thu, 11 Aug 2022 17:33:59 +0200 [thread overview]
Message-ID: <YvUhZ/9Yf7eZ4a32@yuki> (raw)
In-Reply-To: <CAG4es9XhZ7ksvLxwRNO73FC4DQc7KteUQAUPwipbks6kGsvFmw@mail.gmail.com>
Hi!
> I think I finally understand what you mean by this now; it is rather
> strange that the volatility of D does not protect loop from being
> optimized away by the compiler. I don't have a good explanation as to
> why it's happening but I'm not sure how to evaluate what's going on
> either. Should I do anything to move this patch forward?
It all boils down if we want to work around something that looks like a
compiler bug in tests or not. I would be inclined not to do so since LTP
was littered with quite a lot of workarounds for glibc/compiler bugs and
we spend quite some time cleaning that mess up. But in this case I can
agree that this is a borderland issue so I'm not strongly against that
either.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-08-11 15:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 17:39 [LTP] [PATCH v1] syscalls/signal06: add volatile to loop variable Edward Liaw via ltp
2022-07-13 12:48 ` Petr Vorel
2022-07-19 10:20 ` Cyril Hrubis
2022-07-27 21:37 ` Edward Liaw via ltp
2022-08-11 15:24 ` Edward Liaw via ltp
2022-08-11 15:33 ` Cyril Hrubis [this message]
2022-08-16 12:43 ` Petr Vorel
2022-08-16 23:00 ` Edward Liaw via ltp
2022-08-17 9:12 ` Petr Vorel
2022-08-17 15:04 ` Edward Liaw via ltp
2022-08-18 21:18 ` Edward Liaw via ltp
2022-08-19 8:12 ` Petr Vorel
2022-08-19 8:41 ` Cyril Hrubis
2022-08-19 9:02 ` Cyril Hrubis
2022-08-19 9:14 ` Joerg Vehlow
2022-08-19 9:21 ` Cyril Hrubis
2022-08-19 10:40 ` Petr Vorel
2022-08-19 18:13 ` Edward Liaw via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvUhZ/9Yf7eZ4a32@yuki \
--to=chrubis@suse.cz \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox