From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F39EC28D13 for ; Mon, 22 Aug 2022 10:28:45 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id BC0713CA2E6 for ; Mon, 22 Aug 2022 12:28:43 +0200 (CEST) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [IPv6:2001:4b78:1:20::4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id C8AC83CA277 for ; Mon, 22 Aug 2022 12:28:31 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 896DD1000950 for ; Mon, 22 Aug 2022 12:28:30 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D7B3F1F895; Mon, 22 Aug 2022 10:28:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661164109; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v8E18x9ciCb+KkpIp53WDqbk8ru59KRY9oxG2BSBHSo=; b=QlZf7mBk1eDYHVrkIEWgkkA2NVyTrld9Hw4rpybcM1Fh5Vzu8rqAW6fn7+Iac9zj6mh3Ru oZkygB05HImZMFGlV2+Z90mpowcCBvgwJ2rjQMfJSz2clrrEKqUwnWnyVB3R6JZetVDtxV iWGEAo97buArsDyqkhXcQ8eP8LWrA/o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661164109; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=v8E18x9ciCb+KkpIp53WDqbk8ru59KRY9oxG2BSBHSo=; b=FxGgXN7fwHw4mJkkaNcD2Lwh2oBXXAWd/oMXXTwJV8eY/TNxgSUOacEF+V+G5KZjRH0lzU HO1vw8EooVYhqyDw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B58451332D; Mon, 22 Aug 2022 10:28:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jm+BKk1aA2MCDwAAMHmgww (envelope-from ); Mon, 22 Aug 2022 10:28:29 +0000 Date: Mon, 22 Aug 2022 12:28:28 +0200 From: Petr Vorel To: Jan Stancek Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] commands/df01.sh: print more logs when test fails X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: LTP List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > On Fri, Aug 19, 2022 at 5:27 PM Petr Vorel wrote: > > Hi Jan, > > > Signed-off-by: Jan Stancek > > > --- > > > testcases/commands/df/df01.sh | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > diff --git a/testcases/commands/df/df01.sh b/testcases/commands/df/df01.sh > > > index f74032c962e5..6b20f21d0d74 100755 > > > --- a/testcases/commands/df/df01.sh > > > +++ b/testcases/commands/df/df01.sh > > > @@ -103,6 +103,11 @@ df_check() > > > grep ${TST_DEVICE} output | grep -q "${total}.*${used}" > > > if [ $? -ne 0 ]; then > > > + echo "total: ${total}, used: ${used}" > > > + echo "df saved output:" > > I wonder why you didn't use tst_res TINFO? It'd be more readable as the output > > can be quite long... > It didn't cross my mind at the time. It looks like the df failures are > coming to a resolution, > so I don't mind if you want to drop these 'echos' later. Thanks! I wasn't sure if the reason was to print to stdout (tst_res prints to stderr), looks like that was not the reason. Kind regards, Petr > > > + cat output > > > + echo "df output:" > > > + $@ > > Kind regards, > > Petr > > > return 1 > > > fi > > > } -- Mailing list info: https://lists.linux.it/listinfo/ltp