From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9047ECAAD5 for ; Mon, 12 Sep 2022 09:34:56 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 928D23CAABA for ; Mon, 12 Sep 2022 11:34:54 +0200 (CEST) Received: from in-5.smtp.seeweb.it (in-5.smtp.seeweb.it [217.194.8.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 7687E3CA306 for ; Mon, 12 Sep 2022 11:34:44 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-5.smtp.seeweb.it (Postfix) with ESMTPS id D1BDC600691 for ; Mon, 12 Sep 2022 11:34:43 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BE87722938; Mon, 12 Sep 2022 09:34:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1662975282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iQH+bUY/NVEGQjbSO59i2iZ7H0rljlYWnbyXX1ViTcE=; b=dt+w3+OiCWAZDtLmomtPtVubik0R+mF24VwpDR7CVgzFOOLQVt3NtxyQwIx647JlgaavNs umAChzQ6wifb+mtVkLScPalDcjuJIr24Z4P6CcydRBfju+ez5ozMak4IATkKAVMyYhYJZH mMo11C2JgXfxoxwnG7Koi99zeswVcUY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1662975282; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iQH+bUY/NVEGQjbSO59i2iZ7H0rljlYWnbyXX1ViTcE=; b=jTrU0APgTKvzPdwO2HN3x9EPI9qmG/pUlUDwrI0LQpwAGxu72aStvRkq3REMKgg08YWUUU u8x8MhpQYbMlzVBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E53C139C8; Mon, 12 Sep 2022 09:34:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Pt2aJTL9HmO0SAAAMHmgww (envelope-from ); Mon, 12 Sep 2022 09:34:42 +0000 Date: Mon, 12 Sep 2022 11:36:37 +0200 From: Cyril Hrubis To: Petr Vorel Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Virus-Scanned: clamav-milter 0.102.4 at in-5.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] September LTP release X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LTP List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > FYI in minor fanotify cleanup I just wait to get acked TST_EXP_FD_ERRNO [1] > It might be usable only in fanotify, but I'd keep it in tst_test_macros.h > Sooner or later it will be usable by other tests. > I'm also not sure about the name. Since it's calling TST_EXP_FD() or TST_EXP_FAIL() the logical name for it would be TST_EXP_FD_OR_FAIL() > If you like this idea, in the future we might > add more TST_EXP_*_ERRNO(SCALL, ERRNO, ...) macros, i.e. calling TST_EXP_FAIL or TST_EXP_PASS > (thus name could be TST_EXP_PASS_FAIL). Without _OR_ between PASS and FAIL the name is kind of confusing. And it's not that much better even as TST_EXP_PASS_OR_FAIL() but I cannot think of anything better at the moment. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp