From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28B83ECAAD5 for ; Mon, 12 Sep 2022 05:40:29 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 7AD723CAABA for ; Mon, 12 Sep 2022 07:40:27 +0200 (CEST) Received: from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it [217.194.8.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id BBE443CA6DA for ; Mon, 12 Sep 2022 07:40:17 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-6.smtp.seeweb.it (Postfix) with ESMTPS id B7D6D14002C6 for ; Mon, 12 Sep 2022 07:40:16 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4CA9E1F91D; Mon, 12 Sep 2022 05:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1662961214; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JqroxUjqyjSOWPdOBhE3gSmCV9vlO/xoWvJ8HBzVzLs=; b=vHTEPe/5ZL8ek5FtfnJAP7CduDAGQcoLXRc0Ppg7Jms/OAVvXIaVoj29fXyOJEe3D/ig4Z YZo/iJscZf783sm9HvSZP6CDfQFhWvIBqLiYPLMpDeB6X/0SzNB+JObWgi5uw2ublJ2fsI /PwxG1KK6YqN/r74cs1LhzAXLBXmbEg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1662961214; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JqroxUjqyjSOWPdOBhE3gSmCV9vlO/xoWvJ8HBzVzLs=; b=G165kY40yi6ereoub3zXM2uAv/brXw5sBEhRG+wxcEcWgl1ud3EYU0ZnpJhrOjlp4dYxj9 9wCE01ajNghj+vBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0137D139C8; Mon, 12 Sep 2022 05:40:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jBgtOj3GHmNBZwAAMHmgww (envelope-from ); Mon, 12 Sep 2022 05:40:13 +0000 Date: Mon, 12 Sep 2022 07:40:12 +0200 From: Petr Vorel To: Martin Doucha Message-ID: References: <20220902133710.1785-5-pvorel@suse.cz> <70df29e7-0097-c698-b6ba-e3f87da3893f@suse.cz> <5e01e854-7cc6-7b08-d1f8-7f0709fbc07d@suse.cz> <5aae1278-8c6c-febf-7ee3-fe5e508ffdd1@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5aae1278-8c6c-febf-7ee3-fe5e508ffdd1@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-6.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v4 4/9] tst_supported_fs: Support skip list when query single fs X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it, Richard Palethorpe Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" > On 09. 09. 22 16:47, Petr Vorel wrote: > > > One more thing, the skiplist check should be done before availability check. > > > It's faster and it'll save you work when you're trying to fix tests that > > > shouldn't be skipped. > > Good point. I guess you mean just to reverse order in > > tst_fs_is_supported_skiplist(), right? > Exactly. +1 > > +++ lib/tst_supported_fs_types.c > > @@ -137,17 +137,10 @@ enum tst_fs_impl tst_fs_is_supported(const char *fs_type) > > enum tst_fs_impl tst_fs_is_supported_skiplist(const char *fs_type, const char > > *const *skiplist) > > { > > - int ret; > > - > > - ret = tst_fs_is_supported(fs_type); > > - > > - if (!ret) > > - return ret; > > - > > if (tst_fs_in_skiplist(fs_type, skiplist)) > > return TST_FS_UNSUPPORTED; > > - return ret; > > + return tst_fs_is_supported(fs_type); > > } > > const char **tst_get_supported_fs_types(const char *const *skiplist) FYI if anybody wants to test v5 with this fix, it's in my fork in branch shell/all_filesystems.v5.fixes https://github.com/pevik/ltp/commits/shell/all_filesystems.v5.fixes Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp