From: Petr Vorel <pvorel@suse.cz>
To: Yang Xu <xuyang2018.jy@fujitsu.com>
Cc: Joerg Vehlow <joerg.vehlow@aox.de>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] README: Add missing configure in openposix step
Date: Thu, 1 Sep 2022 13:05:19 +0200 [thread overview]
Message-ID: <YxCR7+dkGxPvCQDn@pevik> (raw)
In-Reply-To: <1662008249-2227-1-git-send-email-xuyang2018.jy@fujitsu.com>
Hi Xu,
[ Cc Joerg ]
> Since 8071ba7("openposix: Setup autoconf and fix installation layout")
> , we need to use configure firstly.
nit: there should be Fixes: below:
Fixes: 8071ba7 ("openposix: Setup autoconf and fix installation layout")
Then you can use just 8071ba7 in the text.
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
> README.md | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> diff --git a/README.md b/README.md
> index d45d1ee44..d0ca5f4d4 100644
> --- a/README.md
> +++ b/README.md
> @@ -79,11 +79,13 @@ $ cd ../commands/foo
> $ PATH=$PATH:$PWD:$PWD/../../lib/ ./foo01.sh
> ```
> -Open Posix Testsuite has it's own build system which needs Makefiles to be
> -generated first, then compilation should work in subdirectories as well.
> +Open Posix Testsuite has it's own configure and build system which needs
> +Makefiles to be generated first, then compilation should work in subdirectories
> +as well.
> ```
> $ cd testcases/open_posix_testsuite/
You miss:
$ make autotools
as this creates configure
> +$ ./configure
But if you run make autotools && ./configure in the top level, none of these two
is needed to be run in open posix directory. Maybe document it (not sure about
the comments)?
$ [ -f ./configure ] || make autotools # not needed if run in the top level
$ [ -f include/mk/config.mk ] || ./configure # not needed if the top level configure is run
Kind regards,
Petr
> $ make generate-makefiles
> $ cd conformance/interfaces/foo
> $ make
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-01 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 4:57 [LTP] [PATCH] README: Add missing configure in openposix step Yang Xu
2022-09-01 11:05 ` Petr Vorel [this message]
2022-09-02 7:31 ` xuyang2018.jy
2022-09-19 5:17 ` Joerg Vehlow
2022-09-19 6:06 ` xuyang2018.jy
2022-09-21 11:26 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxCR7+dkGxPvCQDn@pevik \
--to=pvorel@suse.cz \
--cc=joerg.vehlow@aox.de \
--cc=ltp@lists.linux.it \
--cc=xuyang2018.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox