From: Petr Vorel <pvorel@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.de>
Cc: ltp@lists.linux.it, automated-testing@yoctoproject.org
Subject: Re: [LTP] [PATCH v3 01/10] tst_test.sh: Fix tst_mkfs() for tmpfs
Date: Fri, 2 Sep 2022 12:22:25 +0200 [thread overview]
Message-ID: <YxHZYRyIRrCe4QDX@pevik> (raw)
In-Reply-To: <878rn2151o.fsf@suse.de>
> Petr Vorel <pvorel@suse.cz> writes:
> > Hi Richie,
> >> Hello,
> >> No response and seems reasonable, please merge!
> >> Acked-by: Richard Palethorpe <rpalethorpe@suse.com>
> > Thanks a lot for your review! I suppose you mean your ack for whole patchset.
> > If yes, I'll merge all but the last RFC commit which needs more work (i.e.
> > TST_ALL_FILESYSTEMS infrastructure although nothing uses it yet).
> > Merging would help me not having to rebase this work after finishing and get
> > merged "Track minimal size per filesystem" [1] (originally I thought that one
> > would go first, but TST_ALL_FILESYSTEMS infrastructure is ready now).
> > I also plan to convert df01.sh and mkfs01.sh to TST_ALL_FILESYSTEMS.
> > Kind regards,
> > Petr
> > [1] https://patchwork.ozlabs.org/project/ltp/list/?series=315621
> OK, I have acked everything that didn't already have a review tag. It
> would help to include some test conversions in the patch set, but I
> trust you will follow up with df01.sh and mkfs01.sh ;-)
Thanks! As I found that there is tiny issue in TST_ALL_FILESYSTEMS
implementation (there should be equivalent of tst_device->fs_type)
I've merged patches up to "[v3,04/10] tst_mount_device.sh: Cover early
tst_umount call" and send v4 with fixed this version and converted at least one
of df01.sh and mkfs01.sh. Then I base "Track minimal size per filesystem"
patchset on this work (suppose this patchet will be quickly re-reviewed).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-02 10:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 12:19 [LTP] [PATCH v3 00/10] shell: nfs: $TST_ALL_FILESYSTEMS (.all_filesystems) Petr Vorel
2022-08-04 12:19 ` [LTP] [PATCH v3 01/10] tst_test.sh: Fix tst_mkfs() for tmpfs Petr Vorel
2022-09-02 9:18 ` Richard Palethorpe
2022-09-02 9:34 ` Petr Vorel
2022-09-02 9:44 ` Richard Palethorpe
2022-09-02 10:22 ` Petr Vorel [this message]
2022-08-04 12:19 ` [LTP] [PATCH v3 02/10] tst_device: Add clear command Petr Vorel
2022-08-04 12:19 ` [LTP] [PATCH v3 03/10] tst_test.sh: Allow $ ; after whitelisted variable Petr Vorel
2022-09-02 9:31 ` Richard Palethorpe
2022-08-04 12:19 ` [LTP] [PATCH v3 04/10] tst_mount_device.sh: Cover early tst_umount call Petr Vorel
2022-09-02 9:32 ` Richard Palethorpe
2022-08-04 12:19 ` [LTP] [PATCH v3 05/10] tst_supported_fs: Implement skip list Petr Vorel
2022-09-02 9:43 ` Richard Palethorpe
2022-08-04 12:19 ` [LTP] [PATCH v3 06/10] tst_supported_fs: Support skip list when query single fs Petr Vorel
2022-09-02 9:38 ` Richard Palethorpe
2022-08-04 12:19 ` [LTP] [PATCH v3 07/10] shell: Add $TST_SKIP_FILESYSTEMS + tests Petr Vorel
2022-09-02 9:39 ` Richard Palethorpe
2022-08-04 12:19 ` [LTP] [PATCH v3 08/10] tst_test.sh: Add $TST_ALL_FILESYSTEMS Petr Vorel
2022-09-02 9:40 ` Richard Palethorpe
2022-08-04 12:19 ` [LTP] [PATCH v3 09/10] shell: Add test for TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-09-02 9:40 ` Richard Palethorpe
2022-08-04 12:19 ` [LTP] [RFC][PATCH v3 10/10] nfs: Use TST_ALL_FILESYSTEMS=1 Petr Vorel
2022-09-02 9:26 ` [LTP] [PATCH v3 00/10] shell: nfs: $TST_ALL_FILESYSTEMS (.all_filesystems) Richard Palethorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxHZYRyIRrCe4QDX@pevik \
--to=pvorel@suse.cz \
--cc=automated-testing@yoctoproject.org \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox