From: Petr Vorel <pvorel@suse.cz>
To: Edward Liaw <edliaw@google.com>
Cc: kernel-team@android.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] Revert "m4: Remove check for io_set_eventfd"
Date: Mon, 5 Sep 2022 16:08:15 +0200 [thread overview]
Message-ID: <YxYCz1RX7xcLgWin@pevik> (raw)
In-Reply-To: <20220902204539.1035669-1-edliaw@google.com>
Hi Edward,
> This reverts commit 5ca0d16d66c42fbfa483c180de4c881de7f182cc.
> Android has libaio headers but is missing some functions including
> io_set_eventfd. Without these checks it will fail to compile.
Ack to revert as I guess we cannot avoid this. But we should fix newly
introduced warnings on 2.71:
configure.ac:391: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:391: You should run autoupdate.
./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from...
m4/ltp-eventfd.m4:6: LTP_CHECK_SYSCALL_EVENTFD is expanded from...
configure.ac:391: the top level
-AC_TRY_LINK([
+AC_LINK_IFELSE([AC_LANG_PROGRAM([[
...
-],
+]],
NOTE: if you don't have 2.71 available I can fix this myself.
...
> +++ b/testcases/kernel/syscalls/eventfd/eventfd01.c
> @@ -1,6 +1,5 @@
> /*
> * Copyright (c) 2008 Vijay Kumar B. <vijaykumar@bravegnu.org>
> - * Copyright (c) Linux Test Project, 2008-2022
NOTE for person who merges this: this copyright should be kept (amend the commit
before merge).
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2022-09-05 14:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 20:45 [LTP] [PATCH v1] Revert "m4: Remove check for io_set_eventfd" Edward Liaw via ltp
2022-09-05 14:08 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxYCz1RX7xcLgWin@pevik \
--to=pvorel@suse.cz \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox