From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: kernel-team@android.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1] minmax: fix type warnings
Date: Wed, 14 Sep 2022 15:35:56 +0200 [thread overview]
Message-ID: <YyHYvCr0PISg6ISY@pevik> (raw)
In-Reply-To: <YyGisrbDIgVa/0QA@yuki>
> Hi!
> > SAFE_SYSINFO(&info);
> > safety = MAX(4096 * SAFE_SYSCONF(_SC_PAGESIZE), 128L * 1024 * 1024);
> > - safety = MAX(safety, min_free);
> > + safety = MAX(safety, (size_t)min_free);
> > safety /= info.mem_unit;
> We can define the min_free to be size_t from the start as:
Indeed, that's much better. And the second one as well.
Going to merged with these fixes.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-14 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 20:28 [LTP] [PATCH v1] minmax: fix type warnings Edward Liaw via ltp
2022-09-14 9:20 ` Petr Vorel
2022-09-14 9:45 ` Cyril Hrubis
2022-09-14 13:35 ` Petr Vorel [this message]
2022-09-14 13:50 ` Petr Vorel
2022-09-15 20:51 ` Edward Liaw via ltp
2022-09-16 9:13 ` Cyril Hrubis
2022-09-26 18:15 ` Edward Liaw via ltp
2022-09-27 9:06 ` Cyril Hrubis
2022-09-27 21:20 ` Edward Liaw via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyHYvCr0PISg6ISY@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=kernel-team@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox