From: Petr Vorel <pvorel@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] getitimer03.c: convert to new LTP API
Date: Wed, 14 Sep 2022 22:52:57 +0200 [thread overview]
Message-ID: <YyI/KU10+zSi7Fpj@pevik> (raw)
In-Reply-To: <CAEemH2eCd43jRJmYgEB6RpACqcd3gXudSE4UM2p2SwsOjMgN7A@mail.gmail.com>
Hi Avinesh, Li,
> Hi Avinesh,
> Thank you for doing this. The code achievement is absolutely right but
> we can do something unify to better manage the error test in LTP.
> My suggestion is to combine this invalid-argument test into getitimer02.c
> by creating a structure that populates with arguments of getitimer(). Then
> we can traversal each item to complete all error tests for a syscall just
> in one testcase. (see madvise02.c)
Avinesh, do you plan to follow Li's suggestion (which makes sense) and send a
patch this week (e.g. before git freeze due LTP releasing process?)
Kind regards,
Petr
> e.g.
> static struct tcase {
> int which;
> struct itimerval *curr_value;
> } tcases[] = {
> {},
> };
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-14 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 10:44 [LTP] [PATCH] getitimer03.c: convert to new LTP API Avinesh Kumar
2022-07-21 4:04 ` Li Wang
2022-09-14 20:52 ` Petr Vorel [this message]
2022-09-15 7:49 ` [LTP] [PATCH v2] " Li Wang
2022-09-15 10:00 ` Avinesh Kumar
2022-09-16 2:12 ` Li Wang
2022-10-09 3:33 ` Li Wang
2022-10-10 6:30 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyI/KU10+zSi7Fpj@pevik \
--to=pvorel@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox