From: Cyril Hrubis <chrubis@suse.cz>
To: Zhao Gongyi <zhaogongyi@huawei.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs
Date: Thu, 15 Sep 2022 11:49:24 +0200 [thread overview]
Message-ID: <YyL1JKnf/tnapqN2@yuki> (raw)
In-Reply-To: <20220915062715.233884-2-zhaogongyi@huawei.com>
Hi!
> Add .needs_kconfigs for io_uring01.c/io_uring02.c.
We do call io_uring_supported_by_kernel() in the setup() of these tests
so this shouldn't be needed at all. What is the problem you are trying
to fix?
> Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
> ---
> testcases/kernel/syscalls/io_uring/io_uring01.c | 4 ++++
> testcases/kernel/syscalls/io_uring/io_uring02.c | 4 ++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/testcases/kernel/syscalls/io_uring/io_uring01.c b/testcases/kernel/syscalls/io_uring/io_uring01.c
> index 70151bb85..cb1cabcb7 100644
> --- a/testcases/kernel/syscalls/io_uring/io_uring01.c
> +++ b/testcases/kernel/syscalls/io_uring/io_uring01.c
> @@ -261,6 +261,10 @@ static struct tst_test test = {
> .test = run,
> .needs_tmpdir = 1,
> .tcnt = ARRAY_SIZE(tcases),
> + .needs_kconfigs = (const char *const[]){
> + "CONFIG_IO_URING=y",
> + NULL
> + },
> .bufs = (struct tst_buffers []) {
> {&iov, .iov_sizes = (int[]){BLOCK_SZ, -1}},
> {}
> diff --git a/testcases/kernel/syscalls/io_uring/io_uring02.c b/testcases/kernel/syscalls/io_uring/io_uring02.c
> index c5c770074..c7ea87ae5 100644
> --- a/testcases/kernel/syscalls/io_uring/io_uring02.c
> +++ b/testcases/kernel/syscalls/io_uring/io_uring02.c
> @@ -255,6 +255,10 @@ static struct tst_test test = {
> TST_CAP(TST_CAP_REQ, CAP_SYS_CHROOT),
> {}
> },
> + .needs_kconfigs = (const char *const[]){
> + "CONFIG_IO_URING=y",
> + NULL
> + },
> .tags = (const struct tst_tag[]) {
> {"linux-git", "9392a27d88b9"},
> {"linux-git", "ff002b30181d"},
> --
> 2.17.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-15 9:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 6:27 [LTP] [PATCH 0/2] Optimize io_uring related testcases Zhao Gongyi via ltp
2022-09-15 6:27 ` [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs Zhao Gongyi via ltp
2022-09-15 9:49 ` Cyril Hrubis [this message]
2022-09-15 6:27 ` [LTP] [PATCH 2/2] io_uring.h: Remove io_uring_setup_supported_by_kernel() Zhao Gongyi via ltp
2022-09-15 10:01 ` Cyril Hrubis
2022-09-15 10:03 ` Cyril Hrubis
-- strict thread matches above, loose matches on Subject: below --
2022-09-15 9:53 [LTP] [PATCH 1/2] syscalls/io_uring: Add .needs_kconfigs zhaogongyi via ltp
2022-09-15 10:02 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YyL1JKnf/tnapqN2@yuki \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
--cc=zhaogongyi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox